-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rserve integration #120
Comments
We've integrated Rserve in Dataverse Docker module, I don't know if you want to host a separated Docker images for that: |
IMHO this should be kept apart. I do believe in the UNIX philosophy "do one thing, do it well". This gives more flexibility for people that might want to run their own services, use special flavors, install certain amount of packages, ... |
Ok, you should contact people from Rserve then. |
If it helps, I've been happily using Rserve on Dataverse spun up by dataverse-ansible since @donsizemore implemented it over the summer: IQSS/dataverse-ansible#87 Data Explorer didn't work properly without it. It takes time to compile all the R modules so I sometimes comment it out if I don't need the functionality. |
@pdurbin you may also set |
@donsizemore, in the same time it's not really sustainable if Dataverse is relying on an external R service that should do data processing. |
On a related note, we've considered splitting the "ingest" service out of the Dataverse monolith and into its own microservice: IQSS/dataverse#2331 Not all installations of Dataverse want ingest (I'm thinking of Pete's structural biology datasets) but I suspect most do. 😄 |
@4tikhonov note that Akio's TRSA branch https://github.com/OdumInstitute/trsa-web/tree/jee8line carves ingest out of Dataverse proper and at present makes it optional to the end user. what would you prefer Dataverse use in addition to or instead of R? |
I'd really love to discuss this matter in more depth, but I'm pretty sure this is beyond the scope of this issue. Maybe some of you guys can open an issue at IQSS/dataverse, so it reaches even more people interested in ingest? |
@pdurbin : Regarding the R script that runs on Rserve and produces metadata summaries:
cc/ @tercer |
@raprasad, I really like this solution as python microservice. Not because we're "at home" with python but because it can be more sustainable in the long term perspective. |
@raprasad wonderful news! Go @aaron-lebo go! |
@raprasad is the JSON emitted from your new Python code backward compatible with the JSON emitted from the old/current R code? If not, would it be possible to make it backward compatible? I don't want Data Explorer (my main reason for wanting this JSON) to break if we switch to backward-incompatible JSON produced by new code. Now that we (finally) have API tests running automatically on "develop" and pull requests (on https://jenkins.dataverse.org thanks to the absolutely heroic efforts of @donsizemore !!! 🎉 🎉 🎉 ), we could start to make assertions on the old/current JSON format so that any backward incompatibilities would be detected. Writing those assertions might be a good first small chunk. If someone wants to create an issue about this at https://github.com/IQSS/dataverse/issues please go ahead! 😄 |
@pdurbin We will add the backward compatibility to the library. Pleae add comments that may be relevant: TwoRavens/raven-metadata-service#205 |
Some ingest functionality does not work without an Rserve server.
Looks like https://github.com/ubc/r-docker is a trustworthy image, coming from University of British Columbia.
Maybe open an issue over there asking what their plans are on supporting and pushing updated images to Docker Hub: https://hub.docker.com/r/ubcctlt/rserve
The text was updated successfully, but these errors were encountered: