strategies.e2e-spec.ts

import {browser, element, by, protractor} from 'protractor';

/**
 * Strategy screen tests.
 *
 * See: http://www.protractortest.org/#/tutorial
 *
 * TODO - Use by.repeater()/model() instead of by.css() once Angular implement it for lists:
 * https://angular.io/docs/ts/latest/guide/upgrade.html
 * https://github.com/angular/protractor/issues/3205
 *
 * @author gazbert
 */
describe('Strategy Tests', function () {

    const WAIT_TIMEOUT = 300000;

    beforeEach(function () {
        browser.get('');
    });

    it('should update Strategy fields after Save', function () {

        const dashboardItems = element.all(by.css('app-bxbot-ui-dashboard-item'));

        // https://stackoverflow.com/questions/28464604/more-than-one-element-found-for-locator-warning
        const EC = protractor.ExpectedConditions;
        const dashboard = element(by.id('dashboard-grid'));
        browser.wait(EC.visibilityOf(dashboard), WAIT_TIMEOUT);

        dashboardItems.get(3).click();
        expect(element(by.css('h2')).getText()).toEqual('ItBit Bot Details');

        const tabLinks = element.all(by.css('li'));
        tabLinks.get(3).click();

        // Strat 1
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');

        // Update Strat 1 fields
        const strategyName = element(by.id('strategyName_0'));
        const newStrategyName = 'EMA Indicator 2';
        strategyName.clear();
        strategyName.sendKeys(newStrategyName);
        expect(strategyName.getAttribute('value')).toBe(newStrategyName);

        const strategyDescription = element(by.id('strategyDescription_0'));
        const newStrategyDescription = 'EMA Indicator algo for deciding when to enter and exit trades.';
        strategyDescription.clear();
        strategyDescription.sendKeys(newStrategyDescription);
        expect(strategyDescription.getAttribute('value')).toBe(newStrategyDescription);

        const strategyClassName = element(by.id('strategyClassname_0'));
        const newStrategyClassName = 'com.gazbert.bxbot.strategies2.EmaIndicator2';
        strategyClassName.clear();
        strategyClassName.sendKeys(newStrategyClassName);
        expect(strategyClassName.getAttribute('value')).toBe(newStrategyClassName);

        // Save and check the update worked
        const saveButton = element(by.id('strategySaveButton'));
        saveButton.click();
        dashboardItems.get(3).click();
        tabLinks.get(3).click();

        // Strat 1 updated
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe(newStrategyName);
        expect(element(by.id('strategyDescription_0')).getAttribute('value')).toBe(newStrategyDescription);
        expect(element(by.id('strategyClassname_0')).getAttribute('value')).toBe(newStrategyClassName);

        // Strat 2 unchanged
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');
    });

    it('should NOT update Strategy fields after Cancel', function () {

        const dashboardItems = element.all(by.css('app-bxbot-ui-dashboard-item'));

        const EC = protractor.ExpectedConditions;
        const dashboard = element(by.id('dashboard-grid'));
        browser.wait(EC.visibilityOf(dashboard), WAIT_TIMEOUT);

        dashboardItems.get(3).click();
        expect(element(by.css('h2')).getText()).toEqual('ItBit Bot Details');

        const tabLinks = element.all(by.css('li'));
        tabLinks.get(3).click();

        // Strat 1
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');

        // Update Strat 1 fields
        const strategyName = element(by.id('strategyName_0'));
        const newStrategyName = 'EMA Indicator';
        strategyName.clear();
        strategyName.sendKeys(newStrategyName);
        expect(strategyName.getAttribute('value')).toBe(newStrategyName);

        const strategyDescription = element(by.id('strategyDescription_0'));
        const newStrategyDescription = 'EMA Indicator algo for deciding when to enter and exit trades.';
        strategyDescription.clear();
        strategyDescription.sendKeys(newStrategyDescription);
        expect(strategyDescription.getAttribute('value')).toBe(newStrategyDescription);

        const strategyClassName = element(by.id('strategyClassname_0'));
        const newStrategyClassName = 'com.gazbert.bxbot.strategies.EmaIndicator';
        strategyClassName.clear();
        strategyClassName.sendKeys(newStrategyClassName);
        expect(strategyClassName.getAttribute('value')).toBe(newStrategyClassName);

        // Cancel and check the update did not persist
        const cancelButton = element(by.id('strategyCancelButton'));
        cancelButton.click();
        dashboardItems.get(3).click();
        tabLinks.get(3).click();

        // Strat 1 unchanged
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2 unchanged
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');
    });

    it('should add new Strategy and save it', function () {

        const dashboardItems = element.all(by.css('app-bxbot-ui-dashboard-item'));

        const EC = protractor.ExpectedConditions;
        const dashboard = element(by.id('dashboard-grid'));
        browser.wait(EC.visibilityOf(dashboard), WAIT_TIMEOUT);

        dashboardItems.get(3).click();
        expect(element(by.css('h2')).getText()).toEqual('ItBit Bot Details');

        const tabLinks = element.all(by.css('li'));
        tabLinks.get(3).click();

        // Strat 1
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');

        // Add new Strat 3
        const adStrategyLink = element(by.id('addStrategyLink'));
        adStrategyLink.click();

        const strategyName = element(by.id('strategyName_2'));
        const newStrategyName = 'EMA Indicator';
        strategyName.clear();
        strategyName.sendKeys(newStrategyName);
        expect(strategyName.getAttribute('value')).toBe(newStrategyName);

        const strategyDescription = element(by.id('strategyDescription_2'));
        const newStrategyDescription = 'EMA Indicator algo for deciding when to enter and exit trades.';
        strategyDescription.clear();
        strategyDescription.sendKeys(newStrategyDescription);
        expect(strategyDescription.getAttribute('value')).toBe(newStrategyDescription);

        const strategyClassName = element(by.id('strategyClassname_2'));
        const newStrategyClassName = 'com.gazbert.bxbot.strategies.EmaIndicator';
        strategyClassName.clear();
        strategyClassName.sendKeys(newStrategyClassName);
        expect(strategyClassName.getAttribute('value')).toBe(newStrategyClassName);

        // Save and check the update worked
        const saveButton = element(by.id('strategySaveButton'));
        saveButton.click();
        dashboardItems.get(3).click();
        tabLinks.get(3).click();

        // Strat 1 unchanged
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value')).toBe(
            'Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value')).toBe(
            'com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2 unchanged
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');

        // Hello Strat 3!
        expect(element(by.id('strategyName_2')).getAttribute('value')).toBe(newStrategyName);
        expect(element(by.id('strategyDescription_2')).getAttribute('value')).toBe(newStrategyDescription);
        expect(element(by.id('strategyClassname_2')).getAttribute('value')).toBe(newStrategyClassName);
    });

    it('should delete Strategy and save change', function () {

        const dashboardItems = element.all(by.css('app-bxbot-ui-dashboard-item'));

        const EC = protractor.ExpectedConditions;
        const dashboard = element(by.id('dashboard-grid'));
        browser.wait(EC.visibilityOf(dashboard), WAIT_TIMEOUT);

        dashboardItems.get(3).click();
        expect(element(by.css('h2')).getText()).toEqual('ItBit Bot Details');

        const tabLinks = element.all(by.css('li'));
        tabLinks.get(3).click();

        // Strat 1
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');

        // Delete Strat 1
        const deleteStrategyButton = element(by.id('deleteStrategyButton_0'));
        deleteStrategyButton.click();

        // Save and check the update worked
        const saveButton = element(by.id('strategySaveButton'));
        saveButton.click();
        dashboardItems.get(3).click();
        tabLinks.get(3).click();

        // Original Strat 1 'Long Scalper' deleted; new Strat 1 is 'MACD Indicator' (previously Strat 2).
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_0')).getAttribute('value')).toBe(
            'MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value')).toBe(
            'com.gazbert.bxbot.strategies.MacdStrategy');

        // Original Strat 2 moved
        expect(element(by.id('strategyName_1')).isPresent()).toBe(false);
        expect(element(by.id('strategyDescription_1')).isPresent()).toBe(false);
        expect(element(by.id('strategyClassname_1')).isPresent()).toBe(false);
    });

    it('should NOT delete Strategy if currently being used by a Market', function () {

        const dashboardItems = element.all(by.css('app-bxbot-ui-dashboard-item'));

        const EC = protractor.ExpectedConditions;
        const dashboard = element(by.id('dashboard-grid'));
        browser.wait(EC.visibilityOf(dashboard), WAIT_TIMEOUT);

        dashboardItems.get(3).click();
        expect(element(by.css('h2')).getText()).toEqual('ItBit Bot Details');

        const tabLinks = element.all(by.css('li'));
        tabLinks.get(3).click();

        // Strat 1
            expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');

        // Delete Strat 2 - will cause error
        const deleteStrategyButton = element(by.id('deleteStrategyButton_1'));
        deleteStrategyButton.click();

        // Expect error modal to pop up to alert user
        expect(element(by.css('.modal-title')).getText()).toBe('Strategy Still In Use');
        expect(element(by.css('.modal-body')).getText()).toContain(
            'You cannot delete this Strategy because it is still being used by a Market on the Exchange.');

        const modalCloseButton = element(by.id('cannotDeleteStrategyModalCloseButton'));
        modalCloseButton.click();

        // Strat 1 unchanged
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2 unchanged
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');
    });

    it('should add new Optional Config Item and save it', function () {

        const dashboardItems = element.all(by.css('app-bxbot-ui-dashboard-item'));

        const EC = protractor.ExpectedConditions;
        const dashboard = element(by.id('dashboard-grid'));
        browser.wait(EC.visibilityOf(dashboard), WAIT_TIMEOUT);

        dashboardItems.get(3).click();
        expect(element(by.css('h2')).getText()).toEqual('ItBit Bot Details');

        const tabLinks = element.all(by.css('li'));
        tabLinks.get(3).click();

        // Strat 1
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');

        // Add new Config Item to Strat 1
        const optionalStrategyConfigButton = element(by.id('optionalStrategyConfigButton_0'));
        optionalStrategyConfigButton.click();

        // Need to wait for link to become visible...
        const addConfigItemLink = element(by.id('addNewStrategyConfigItemLink_0'));
        browser.wait(EC.visibilityOf(addConfigItemLink), WAIT_TIMEOUT);
        addConfigItemLink.click();

        // Wait for new item to panel to become visible...
        const strategyConfigItemName = element(by.id('strategyConfigItemName_0_1'));
        browser.wait(EC.visibilityOf(strategyConfigItemName), WAIT_TIMEOUT);

        const newConfigItemName = 'stop-loss-percentage-trigger';
        strategyConfigItemName.clear();
        strategyConfigItemName.sendKeys(newConfigItemName);
        expect(strategyConfigItemName.getAttribute('value')).toBe(newConfigItemName);

        const strategyConfigItemValue = element(by.id('strategyConfigItemValue_0_1'));
        const newConfigItemValue = '8.0';
        strategyConfigItemValue.clear();
        strategyConfigItemValue.sendKeys(newConfigItemValue);
        expect(strategyConfigItemValue.getAttribute('value')).toBe(newConfigItemValue);

        // Save and check the update worked
        const saveButton = element(by.id('strategySaveButton'));
        saveButton.click();
        dashboardItems.get(3).click();
        tabLinks.get(3).click();

        // Strat 1 - the same + 1 new config item
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');
        expect(element(by.id('strategyConfigItemName_0_0')).getAttribute('value')).toBe('min-percentage-gain');
        expect(element(by.id('strategyConfigItemValue_0_0')).getAttribute('value')).toBe('1.0');

        // New Config Item present
        expect(element(by.id('strategyConfigItemName_0_1')).getAttribute('value')).toBe('stop-loss-percentage-trigger');
        expect(element(by.id('strategyConfigItemValue_0_1')).getAttribute('value')).toBe('8.0');

        // Strat 2 - unchanged
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');
        expect(element(by.id('strategyConfigItemName_1_0')).getAttribute('value')).toBe('ema-short-interval');
        expect(element(by.id('strategyConfigItemValue_1_0')).getAttribute('value')).toBe('12');
        expect(element(by.id('strategyConfigItemName_1_1')).getAttribute('value')).toBe('ema-long-interval');
        expect(element(by.id('strategyConfigItemValue_1_1')).getAttribute('value')).toBe('26');
        expect(element(by.id('strategyConfigItemName_1_2')).getAttribute('value')).toBe('signal-line');
        expect(element(by.id('strategyConfigItemValue_1_2')).getAttribute('value')).toBe('9');
    });

    it('should delete Optional Config Item and save change', function () {

        const dashboardItems = element.all(by.css('app-bxbot-ui-dashboard-item'));

        const EC = protractor.ExpectedConditions;
        const dashboard = element(by.id('dashboard-grid'));
        browser.wait(EC.visibilityOf(dashboard), WAIT_TIMEOUT);

        dashboardItems.get(3).click();
        expect(element(by.css('h2')).getText()).toEqual('ItBit Bot Details');

        const tabLinks = element.all(by.css('li'));
        tabLinks.get(3).click();

        // Strat 1
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');

        // Access Strat 2 optional config
        const optionalStrategyConfigButton = element(by.id('optionalStrategyConfigButton_1'));
        browser.wait(EC.visibilityOf(optionalStrategyConfigButton), WAIT_TIMEOUT);
        optionalStrategyConfigButton.click();

        // Delete Config Item 1 from Strat 2
        // Need to wait for link + config items to become visible...
        const deleteConfigItemButton = element(by.id('deleteConfigItemButton_1_0'));
        browser.wait(EC.visibilityOf(deleteConfigItemButton), WAIT_TIMEOUT);
        deleteConfigItemButton.click();

        // Save and check the update worked
        const saveButton = element(by.id('strategySaveButton'));
        browser.wait(EC.visibilityOf(saveButton), WAIT_TIMEOUT);
        saveButton.click();

        browser.wait(EC.visibilityOf(element(by.id('dashboard'))), WAIT_TIMEOUT);
        dashboardItems.get(3).click();
        tabLinks.get(3).click();

        // Strat 1 - the same
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');
        expect(element(by.id('strategyConfigItemName_0_0')).getAttribute('value')).toBe('min-percentage-gain');
        expect(element(by.id('strategyConfigItemValue_0_0')).getAttribute('value')).toBe('1.0');

        // Strat 2 - optional config item 1 gone
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');

        // Deleted!
        // expect(element(by.id('strategyConfigItemName_1_0')).getAttribute('value')).toBe('ema-short-interval');
        // expect(element(by.id('strategyConfigItemValue_1_0')).getAttribute('value')).toBe('12');

        expect(element(by.id('strategyConfigItemName_1_0')).getAttribute('value')).toBe('ema-long-interval');
        expect(element(by.id('strategyConfigItemValue_1_0')).getAttribute('value')).toBe('26');

        expect(element(by.id('strategyConfigItemName_1_1')).getAttribute('value')).toBe('signal-line');
        expect(element(by.id('strategyConfigItemValue_1_1')).getAttribute('value')).toBe('9');
    });

    it('should NOT save Strategy fields if there are validation errors', function () {

        const dashboardItems = element.all(by.css('app-bxbot-ui-dashboard-item'));

        const EC = protractor.ExpectedConditions;
        const dashboard = element(by.id('dashboard-grid'));
        browser.wait(EC.visibilityOf(dashboard), WAIT_TIMEOUT);

        dashboardItems.get(3).click();
        expect(element(by.css('h2')).getText()).toEqual('ItBit Bot Details');

        const tabLinks = element.all(by.css('li'));
        tabLinks.get(3).click();

        // Strat 1
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');

        // Update Strat 1 fields with some 'bad' values
        const strategyName = element(by.id('strategyName_0'));
        strategyName.clear();
        const newStrategyName = 'dodgy n@me';
        strategyName.sendKeys(newStrategyName);
        expect(strategyName.getAttribute('value')).toBe(newStrategyName);

        const strategyDescription = element(by.id('strategyDescription_0'));
        const newStrategyDescription = 'EMA Indicator algo for deciding when to enter and exit trades.';
        strategyDescription.clear();
        strategyDescription.sendKeys(newStrategyDescription);
        expect(strategyDescription.getAttribute('value')).toBe(newStrategyDescription);

        const strategyClassName = element(by.id('strategyClassname_0'));
        const newStrategyClassName = '123BadClassName';
        strategyClassName.clear();
        strategyClassName.sendKeys(newStrategyClassName);
        expect(strategyClassName.getAttribute('value')).toBe(newStrategyClassName);

        // Add new invalid Config Item to Strat 1
        const optionalStrategyConfigButton = element(by.id('optionalStrategyConfigButton_0'));
        optionalStrategyConfigButton.click();

        // Need to wait for link to become visible...
        const addConfigItemLink = element(by.id('addNewStrategyConfigItemLink_0'));
        browser.wait(EC.visibilityOf(addConfigItemLink), WAIT_TIMEOUT);
        addConfigItemLink.click();

        // Wait for new item to panel to become visible...
        const strategyConfigItemName = element(by.id('strategyConfigItemName_0_1'));
        browser.wait(EC.visibilityOf(strategyConfigItemName), WAIT_TIMEOUT);

        const newConfigItemName = 'stop-loss-percentage-tr igger'; // space in name
        strategyConfigItemName.clear();
        strategyConfigItemName.sendKeys(newConfigItemName);
        expect(strategyConfigItemName.getAttribute('value')).toBe(newConfigItemName);

        const strategyConfigItemValue = element(by.id('strategyConfigItemValue_0_1'));
        const newConfigItemValue = ''; // left empty
        strategyConfigItemValue.clear();
        strategyConfigItemValue.sendKeys(newConfigItemValue);
        expect(strategyConfigItemValue.getAttribute('value')).toBe(newConfigItemValue);

        // Save and check the update did not persist
        const saveButton = element(by.id('strategySaveButton'));
        saveButton.click();

        // Strat 1 - check for validation errors
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe(newStrategyName);
        expect(element(by.id('invalidStrategyName_0')).getText()).toBe(
            'Name must be alphanumeric and can only include the following special characters: _ -');

        expect(element(by.id('strategyDescription_0')).getAttribute('value')).toBe(newStrategyDescription);

        expect(element(by.id('strategyClassname_0')).getAttribute('value')).toBe(newStrategyClassName);
        expect(element(by.id('invalidStrategyClassname_0')).getText()).toBe(
            'Class Name must be valid Java class, e.g. com.my.MyTradingStrategyClass');

        expect(element(by.id('strategyConfigItemName_0_1')).getAttribute('value')).toBe('stop-loss-percentage-tr igger');
        expect(element(by.id('invalidStrategyConfigItemName_0_1')).getText()).toContain(
            'Name must be alphanumeric and can only include the following special characters: _ -');

        expect(element(by.id('strategyConfigItemValue_0_1')).getAttribute('value')).toBe('');
        expect(element(by.id('invalidStrategyConfigItemValue_0_1')).getText()).toContain('Value is required');

        // Strat 2 unchanged
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');
    });

    it('should NOT save new Strategy when Strategy Name already in use', function () {

        const dashboardItems = element.all(by.css('app-bxbot-ui-dashboard-item'));

        const EC = protractor.ExpectedConditions;
        const dashboard = element(by.id('dashboard-grid'));
        browser.wait(EC.visibilityOf(dashboard), WAIT_TIMEOUT);

        dashboardItems.get(3).click();
        expect(element(by.css('h2')).getText()).toEqual('ItBit Bot Details');

        const tabLinks = element.all(by.css('li'));
        tabLinks.get(3).click();

        // Strat 1
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value'))
            .toBe('Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');

        // Add new Strat 3 with same name as Strat 2
        const addStrategyLink = element(by.id('addStrategyLink'));
        addStrategyLink.click();

        const strategyName = element(by.id('strategyName_2'));
        const newStrategyName = 'MACD Indicator'; // eek!
        strategyName.clear();
        strategyName.sendKeys(newStrategyName);
        expect(strategyName.getAttribute('value')).toBe(newStrategyName);

        const strategyDescription = element(by.id('strategyDescription_2'));
        const newStrategyDescription = 'EMA Indicator algo for deciding when to enter and exit trades.';
        strategyDescription.clear();
        strategyDescription.sendKeys(newStrategyDescription);
        expect(strategyDescription.getAttribute('value')).toBe(newStrategyDescription);

        const strategyClassName = element(by.id('strategyClassname_2'));
        const newStrategyClassName = 'com.gazbert.bxbot.strategies.EmaIndicator';
        strategyClassName.clear();
        strategyClassName.sendKeys(newStrategyClassName);
        expect(strategyClassName.getAttribute('value')).toBe(newStrategyClassName);

        // Save and check the update failed
        const saveButton = element(by.id('strategySaveButton'));
        saveButton.click();

        // Strat 3 - check for validation errors
        expect(element(by.id('strategyName_2')).getAttribute('value')).toBe(newStrategyName);
        expect(element(by.id('invalidStrategyName_2')).getText()).toBe(
            'Strategy Name already in use on this Exchange. Please choose another.');

        expect(element(by.id('strategyDescription_2')).getAttribute('value')).toBe(newStrategyDescription);
        expect(element(by.id('strategyClassname_2')).getAttribute('value')).toBe(newStrategyClassName);

        // Strat 1 unchanged
        expect(element(by.id('strategyName_0')).getAttribute('value')).toBe('Long Scalper');
        expect(element(by.id('strategyDescription_0')).getAttribute('value')).toBe(
            'Scalping strategy that buys low and sells high.');
        expect(element(by.id('strategyClassname_0')).getAttribute('value')).toBe(
            'com.gazbert.bxbot.strategies.LongScalperStrategy');

        // Strat 2 unchanged
        expect(element(by.id('strategyName_1')).getAttribute('value')).toBe('MACD Indicator');
        expect(element(by.id('strategyDescription_1')).getAttribute('value'))
            .toBe('MACD Indicator algo for deciding when to enter and exit trades.');
        expect(element(by.id('strategyClassname_1')).getAttribute('value'))
            .toBe('com.gazbert.bxbot.strategies.MacdStrategy');
    });
});