Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change position of window controls for InnerWindow #5469

Closed
2 tasks done
Jacalz opened this issue Jan 26, 2025 · 5 comments
Closed
2 tasks done

Change position of window controls for InnerWindow #5469

Jacalz opened this issue Jan 26, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@Jacalz
Copy link
Member

Jacalz commented Jan 26, 2025

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

The InnerWindow currently is very macOS-ish with buttons on the left side and maximize and minimize are switched compared to the positions where they would be on Windows or most Linux distributions (except for Gnome which by default only has a close button, sigh).

Image
Image

Is it possible to construct a solution with the existing API?

Yes

Describe the solution you'd like to see.

For this to match user expectations, I think we need to both set a default depending on the operating system (macOS has left with buttons in current order and all other desktop systems have it on the right with max/min swapped).

@Jacalz Jacalz added the enhancement New feature or request label Jan 26, 2025
@andydotxyz
Copy link
Member

other desktop systems have it on the right with max/min swapped).

Aren't all 3 reversed? or is Close still on the left with max/min swapped?

@Jacalz
Copy link
Member Author

Jacalz commented Jan 27, 2025

You can see in my second image that it isn't just mirrored/reversed to the other side. Maximise is in the middle.

@andydotxyz
Copy link
Member

You can see in my second image that it isn't just mirrored/reversed to the other side. Maximise is in the middle.

Thanks. Given the mismatch of image and text I wanted to double check.

So, if we go with the image, you're really looking for the min/max to stay in the same order with close on the other side of them?

@Jacalz
Copy link
Member Author

Jacalz commented Jan 27, 2025

I don't personally think there is a mismatch between image and text but it doesn't matter much. In case of any confusion, it is the image that should be the reference :)

@andydotxyz
Copy link
Member

Fixed on develop :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants