Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Insert method to Accordion #5419

Closed
2 tasks done
JeffreyLeeLi opened this issue Jan 16, 2025 · 2 comments
Closed
2 tasks done

Add Insert method to Accordion #5419

JeffreyLeeLi opened this issue Jan 16, 2025 · 2 comments

Comments

@JeffreyLeeLi
Copy link

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

I'm frustrated to manipulate Items field directly, 'coz it'll panic.

Is it possible to construct a solution with the existing API?

None works for me now.

Describe the solution you'd like to see.

func (a *Accordion) Insert(index int, item *AccordionItem)

@Jacalz
Copy link
Member

Jacalz commented Jan 16, 2025

I'm not necessarily saying that I'm against adding this, but I want to clarify that "coz it'll panic" is not a good enough reason for adding this. As explained in the previous issue, it panics because of a race condition that that has very likely been fixed on the develop branch for 2.6.

@Jacalz Jacalz changed the title add Insert method to Accordion Add Insert method to Accordion Jan 16, 2025
@JeffreyLeeLi
Copy link
Author

... it panics because of a race condition that that has very likely been fixed on the develop branch for 2.6.

OK. Good news to hear.

Thanks for the explanation.

And I'll wait for the version to release, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants