Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Is this still being maintained? #91

Open
rgeraads opened this issue Jun 20, 2023 · 4 comments
Open

[QUESTION] Is this still being maintained? #91

rgeraads opened this issue Jun 20, 2023 · 4 comments

Comments

@rgeraads
Copy link

Hi! Is this project still being maintained? The last commit is almost 1 year old.

This library runs on php8, but it produces warnings because of missing return types
Return type of Kingsquare\Banking\Transaction::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

@sevannerse
Copy link
Collaborator

Hey, would you consider opening a PR?

@rgeraads
Copy link
Author

that would be a breaking change, because it's only for php8, and the version constraint is >=7

@fruitl00p
Copy link
Owner

Just to chime in here: adding taht as an official typehint will break php7 compat. I'd be open to drop PHP7 and keep the current release as the last 7 compatible version?
(and bump to 3.0 as the first PHP8 only?)

@arendjantetteroo
Copy link

@fruitl00p Are you planning to include the several php 8 deprecation pull requests?.
8.4 is out and includes a few new ones which i included in #92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants