From 880bb0494f59b2082e6c85573b31747fe8ef0100 Mon Sep 17 00:00:00 2001 From: Laurent Demailly Date: Thu, 22 Aug 2024 17:26:15 -0700 Subject: [PATCH 1/2] ping golanglint-ci version pending https://github.com/golangci/golangci-lint-action/issues/1091 --- .github/workflows/gochecks.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/gochecks.yml b/.github/workflows/gochecks.yml index b7aa04c..607afa0 100644 --- a/.github/workflows/gochecks.yml +++ b/.github/workflows/gochecks.yml @@ -27,6 +27,8 @@ jobs: run: curl -fsS -o .golangci.yml https://raw.githubusercontent.com/fortio/workflows/main/golangci.yml - name: Run golangci-lint uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # pin@v6 + with: + version: v1.60.3 - name: Run tests run: | go version From f736f82e85b0076e5dc6c04094f77d14f9a780c3 Mon Sep 17 00:00:00 2001 From: Laurent Demailly Date: Fri, 23 Aug 2024 00:29:21 +0000 Subject: [PATCH 2/2] also disable exportloopref to avoid warning about it --- golangci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/golangci.yml b/golangci.yml index 0865613..3e600b1 100644 --- a/golangci.yml +++ b/golangci.yml @@ -77,6 +77,7 @@ linters: # Deprecated ones: - gomnd - execinquery + - exportloopref # Redundant ones: - gofmt # we use gofumpt # Weird/bad ones: