From 8dbbe8216c52270c7589b7aeeebda254abf0e563 Mon Sep 17 00:00:00 2001 From: Laurent Demailly Date: Tue, 12 Nov 2024 15:02:15 -0800 Subject: [PATCH] Fix mnd still existing (#95) * Fix mnd still existing * update golangci-lint- version --- .github/workflows/gochecks.yml | 2 +- Makefile | 1 + golangci.yml | 1 + testing/workflow_test/main.go | 9 ++++++++- 4 files changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/gochecks.yml b/.github/workflows/gochecks.yml index 4378710..d9192fe 100644 --- a/.github/workflows/gochecks.yml +++ b/.github/workflows/gochecks.yml @@ -34,7 +34,7 @@ jobs: if: matrix.os == 'ubuntu-latest' uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 # pin@v6 with: - version: v1.61.0 + version: v1.62.0 - name: Install Git Bash run: | choco install git diff --git a/Makefile b/Makefile index 0a2b146..49ac003 100644 --- a/Makefile +++ b/Makefile @@ -6,6 +6,7 @@ validate: echo "golangci-lint found, running validation..."; \ golangci-lint version; \ golangci-lint config verify --config golangci.yml || exit 1; \ + golangci-lint run --config golangci.yml || exit 1; \ else \ echo "golangci-lint not found, skipping validation."; \ fi diff --git a/golangci.yml b/golangci.yml index 66f0e57..6d1c1ae 100644 --- a/golangci.yml +++ b/golangci.yml @@ -79,6 +79,7 @@ linters: # Redundant ones: - gofmt # we use gofumpt # Weird/bad ones: + - mnd - wsl - nlreturn - gochecknoinits diff --git a/testing/workflow_test/main.go b/testing/workflow_test/main.go index 18f6a32..9548eae 100644 --- a/testing/workflow_test/main.go +++ b/testing/workflow_test/main.go @@ -1,8 +1,15 @@ // Just to minimally exercise some of the go actions package main -import "fortio.org/scli" +import ( + "runtime" + + "fortio.org/log" + "fortio.org/scli" +) func main() { scli.ServerMain() + _, file, _, ok := runtime.Caller(2) + log.Infof("Just mnd check: %v %v", file, ok) }