Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some comment #51

Open
LuckyPigeon opened this issue Oct 18, 2017 · 3 comments
Open

add some comment #51

LuckyPigeon opened this issue Oct 18, 2017 · 3 comments

Comments

@LuckyPigeon
Copy link

I'm new to this project, and I'm still trying to understand how this work, but it's seems there are less comment in the PyBeacon.py, so I decided to add some comment beside the code, so that when other new come to contribute, they can understand the code faster and quickly get involved.

@PrabhanshuAttri
Copy link
Collaborator

@LuckyPigoen It's a good suggestion. Please go ahead and add comments to PyBeacon/PyBeacon.py. Please do make sure that you follow pep-8 guidelines.

@LuckyPigeon
Copy link
Author

I find that at PyBeacon.py line 88, there's a indent wrong, the "else" is four space less that the "if".
Do I need to create another issue, or just fix it and PR?

@PrabhanshuAttri
Copy link
Collaborator

PrabhanshuAttri commented Mar 14, 2018

@LuckyPigeon Fix it and create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants