Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interesting fix/hack/workaround for 'local' dependencies... #186

Open
floooh opened this issue Jun 13, 2018 · 3 comments
Open

Interesting fix/hack/workaround for 'local' dependencies... #186

floooh opened this issue Jun 13, 2018 · 3 comments
Assignees
@floooh
Labels
enhancement

Comments

@floooh
Copy link
Owner

floooh commented Jun 13, 2018

Interesting idea by @code-disaster: https://gist.github.com/code-disaster/1b99511e0e74b21f97297e7091c56428

A 'real' local dependency mode should probably work in a project subdirectory not under version control (like NPM), but if the changes are small it may make sense to implement the idea in the gist just to enable more scenarios.
@floooh floooh self-assigned this Jun 13, 2018
@code-disaster
Copy link
Contributor

Remotely related corner case: transitive dependencies.

I just imported fips-stb. It has a dependency to fips-glfw, which is only needed to build the examples. Still, in "library mode", it also pulls the glfw dependency into the main project.

A current workaround is to just let the copy sit there (not a big deal), add fips-glfw to fips.yml inside the main project, then exclude it with e.g. cond: "FIPS_NEVER".

@code-disaster
Copy link
Contributor

Oh nvm, I've just seen no_auto_import: true in sokol-samples. Maybe this could be useful as a per-import flag.

@floooh
Copy link
Owner Author

floooh commented Jun 25, 2018

Yep, it's a bit more work to setup no_auto_import projects, but it's created exactly for that reason, to filter out imports that are not needed in some build configs.

code-disaster added a commit to code-disaster/fips that referenced this issue Jul 7, 2018
@code-disaster
print info message on 'fips diag imports' if project dir isn't a git …
dd0ff07 
…repository

see floooh#186 for an outline; this commit just prevents 'fips diag' to falsely report status of a parent repository, if there is one.
@code-disaster code-disaster mentioned this issue Jul 13, 2018
Merged
floooh pushed a commit that referenced this issue Jul 13, 2018
@code-disaster @floooh
Some QoL changes (#196)
adcdadd 
* fix typo in error message

* 'fips clear' only prints configs effectively cleared

* print info message on 'fips diag imports' if project dir isn't a git repository

see #186 for an outline; this commit just prevents 'fips diag' to falsely report status of a parent repository, if there is one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@floooh floooh

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@floooh @code-disaster