Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mbedtls] Add AES part of the library. #4009

Open
csaboka21 opened this issue Nov 18, 2024 · 5 comments
Open

[mbedtls] Add AES part of the library. #4009

csaboka21 opened this issue Nov 18, 2024 · 5 comments
Assignees
Labels
Core+Services HAL, furi & core system services Feature Request New feature or user-story you wanna add to flipper

Comments

@csaboka21
Copy link

Describe the enhancement you're suggesting.

Hi,

I would like to ask to add AES implementation of the mbedtls library.
I would use it in my own app.

Anything else?

No response

@GMMan
Copy link
Contributor

GMMan commented Dec 31, 2024

There are built-in AES functions within furi HAL (see furi_hal_crypto.h), see if those match your needs first. If they don't, you will need to ship your own copy of mbedtls. The built-in mbedtls functions are not exported to the application API.

@bettse
Copy link
Contributor

bettse commented Jan 3, 2025

mbedtls_des_crypt_cbc is included in the API (via fap_libs=["mbedtls"],), I don't see why the AES variants couldn't be made available as well. I would find them useful. There is furi_hal_crypto_decrypt, but that appears to only support AES256, not AES128. I'd be more than happy to be mistaken though.

@GMMan
Copy link
Contributor

GMMan commented Jan 3, 2025

The hardware definitely supports AES128, so maybe it's a small change to enable that in FuriHal. I think hardware AES peripheral use should be encouraged. Having to link mbedtls also bloats the app executable size.

@bettse
Copy link
Contributor

bettse commented Jan 4, 2025

Sure, I don't care how, I'd just like AES128. If they can do it in hardware, that's great, otherwise, mbedtls, and the bloat it adds to my app, would be something I'd accept.

@skotopes skotopes added Core+Services HAL, furi & core system services Feature Request New feature or user-story you wanna add to flipper labels Jan 16, 2025
@skotopes
Copy link
Member

@portasynthinca3 couple things here:

  • update mbedtls to latest version
  • update mbedtls build configuration
  • optional: talk with @hedger about impact on firmware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core+Services HAL, furi & core system services Feature Request New feature or user-story you wanna add to flipper
Projects
None yet
Development

No branches or pull requests

5 participants