Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file for game settings #17

Merged
merged 7 commits into from
Jan 8, 2025
Merged

Config file for game settings #17

merged 7 commits into from
Jan 8, 2025

Conversation

Piturnah
Copy link
Collaborator

@Piturnah Piturnah commented Dec 17, 2022

TODO:

  • Implement config file
  • Default values if not present
  • Warn on unexpected value
  • Serialize Config on change

Will close #15

@Piturnah Piturnah mentioned this pull request Dec 17, 2022
3 tasks
Uses only ECS systems now to tidy it up. Also will log a warning if
there is an unexpected key in the config file.
Add `semicolon_if_nothing_returned` and `uninlined_format_args` for more
consistent code style
We don't need to pretend that we can change the config while the game is
running (yet).
@Piturnah Piturnah marked this pull request as ready for review January 8, 2025 17:28
@Piturnah Piturnah merged commit 23fe763 into main Jan 8, 2025
1 check passed
@Piturnah Piturnah deleted the feat/config branch January 19, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load config file on startup
1 participant