Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: incorrect minFundAmount #12

Open
erhant opened this issue Jan 13, 2025 · 0 comments · May be fixed by #19
Open

bug: incorrect minFundAmount #12

erhant opened this issue Jan 13, 2025 · 0 comments · May be fixed by #19
Labels
bug Something isn't working

Comments

@erhant
Copy link
Member

erhant commented Jan 13, 2025

https://github.com/firstbatchxyz/swan-contracts/blob/master/src/SwanAgent.sol#L171 here it should take 2 * oracleFee because in a round we have 2 oracle requests, one for purchase and one for updateState
@erhant erhant added the bug Something isn't working label Jan 13, 2025
@vivinvinh212 vivinvinh212 linked a pull request Jan 31, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Swan fixes upgrade firstbatchxyz/swan-contracts
1 participant
@erhant