Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement context menu #19

Open
janodvarko opened this issue Apr 6, 2015 · 3 comments
Open

Implement context menu #19

janodvarko opened this issue Apr 6, 2015 · 3 comments

Comments

@janodvarko
Copy link
Member

There should be context menu within the RDP console window.

Honza

@janodvarko
Copy link
Member Author

Possible actions when right-clicking on a packet in the packet list:

  • Copy
  • Cut
  • Remove
  • Resend
  • Edit & Send
  • Insert Summary (after clicked packet)

Honza

@nchevobbe
Copy link

"copy" would be really helpful.
I don't know anything about extensions, but maybe I can try to tackle this ?

@janodvarko
Copy link
Member Author

janodvarko commented Dec 1, 2016

Sounds great!

RDPi is implemented on top of React/Redux libraries so, the architecture should be familiar to folks with this React/Redux experience. I think that no extension specific knowledge is required for this issue.

The list of rendered packets is represented by PacketList component
https://github.com/firebug/rdp-inspector/blob/master/data/inspector/components/packet-list.js

Individual packet rendered in the list is implemented as Packet component
https://github.com/firebug/rdp-inspector/blob/master/data/inspector/components/packet.js

Every packet already has a context menu that appears if the user right-click on it:
https://github.com/firebug/rdp-inspector/blob/master/data/inspector/components/packet.js#L120

There is currently only "Edit and Resend" item and it should be simple to add new using 'li' elements.

Honza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants