From 655609e0d137de3650a80b33570f01ccb191fd1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Elvis=20Nu=C3=B1ez?= Date: Wed, 25 Oct 2017 13:22:38 +0200 Subject: [PATCH] Clean up non-attended TODOs # Conflicts: # Finjinon/CaptureManager.swift # Finjinon/PhotoCollectionViewLayout.swift # Finjinon/PhotoStorage.swift --- Finjinon/CaptureManager.swift | 6 ++---- Finjinon/PhotoCaptureViewController.swift | 2 -- Finjinon/PhotoCollectionViewLayout.swift | 2 -- Finjinon/PhotoStorage.swift | 5 +---- 4 files changed, 3 insertions(+), 12 deletions(-) diff --git a/Finjinon/CaptureManager.swift b/Finjinon/CaptureManager.swift index 579bbdd..ba5eb60 100644 --- a/Finjinon/CaptureManager.swift +++ b/Finjinon/CaptureManager.swift @@ -93,7 +93,7 @@ class CaptureManager: NSObject { } } - func captureImage(_ completion: @escaping (Data, NSDictionary) -> Void) { // TODO: throws + func captureImage(_ completion: @escaping (Data, NSDictionary) -> Void) { captureQueue.async { guard let connection = self.stillImageOutput?.connection(withMediaType: AVMediaTypeVideo) else { return @@ -112,8 +112,7 @@ class CaptureManager: NSObject { } } } else { - NSLog("Failed capturing still imagE: \(String(describing: error))") - // TODO: + NSLog("Failed capturing still images: \(String(describing: error))") } }) } @@ -202,7 +201,6 @@ class CaptureManager: NSObject { if self.session.canAddInput(input) { self.session.addInput(input) } else { - // TODO: handle? NSLog("failed to add input \(input) to session \(self.session)") } } catch let error1 as NSError { diff --git a/Finjinon/PhotoCaptureViewController.swift b/Finjinon/PhotoCaptureViewController.swift index 9e2893d..558003f 100644 --- a/Finjinon/PhotoCaptureViewController.swift +++ b/Finjinon/PhotoCaptureViewController.swift @@ -59,8 +59,6 @@ open class PhotoCaptureViewController: UIViewController, PhotoCollectionViewLayo view.backgroundColor = UIColor.black - // TODO: Move all the boring view setup to a storyboard/xib - previewView = UIView(frame: view.bounds) previewView.autoresizingMask = [.flexibleWidth, .flexibleHeight] view.addSubview(previewView) diff --git a/Finjinon/PhotoCollectionViewLayout.swift b/Finjinon/PhotoCollectionViewLayout.swift index 75c0592..823d228 100644 --- a/Finjinon/PhotoCollectionViewLayout.swift +++ b/Finjinon/PhotoCollectionViewLayout.swift @@ -232,8 +232,6 @@ internal class PhotoCollectionViewLayout: UICollectionViewFlowLayout, UIGestureR case .changed: if let proxy = dragProxy { proxy.center.x = proxy.initialCenter.x + translation.x - // TODO: Constrain to be within collectionView.frame: - // proxy.center.y = proxy.originalCenter.y + translation.y if let fromIndexPath = proxy.dragIndexPath, let toIndexPath = collectionView!.indexPathForItem(at: proxy.center), diff --git a/Finjinon/PhotoStorage.swift b/Finjinon/PhotoStorage.swift index fada18b..3c21116 100644 --- a/Finjinon/PhotoStorage.swift +++ b/Finjinon/PhotoStorage.swift @@ -10,8 +10,6 @@ public enum AssetImageDataSourceTypes { case camera, library, unknown } -// TODO: also support ALAsset/PHPhoto - public struct Asset: Equatable, CustomStringConvertible { public let UUID = Foundation.UUID().uuidString let storage: PhotoStorage @@ -101,7 +99,6 @@ open class PhotoStorage { } catch let error1 as NSError { error = error1 NSLog("Failed to write image to \(cacheURL): \(String(describing: error))") - // TODO: throw } catch { fatalError() } @@ -226,7 +223,7 @@ open class PhotoStorage { completion(thumbnailImage) } } - } // TODO: else throws + } } }