Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Introduce Directory.build.props for shared properties #14826

Open
0x5bfa opened this issue Feb 24, 2024 · 4 comments · May be fixed by #16557
Open

Code Quality: Introduce Directory.build.props for shared properties #14826

0x5bfa opened this issue Feb 24, 2024 · 4 comments · May be fixed by #16557

Comments

@0x5bfa
Copy link
Member

0x5bfa commented Feb 24, 2024 •
edited
Loading

Description

as the title.
Usage: https://github.com/microsoft/devhome/blob/main/Directory.Build.props

Concerned code

  • csproj and vcxproj files

Gains

  • Reduced lines.
  • Avoid forgetting to add required properties
  • Avoid duplications

Requirements

  • Add Directory.build.props in the root
  • Remove diplications

Comments

No response
@gumbarros gumbarros mentioned this issue Mar 19, 2024
Closed
@yaira2
Copy link
Member

yaira2 commented Jun 4, 2024

Can we do this in stages, and start with the duplicate props first?

@0x5bfa
Copy link
Member Author

0x5bfa commented Jun 4, 2024

Yeah starting from

<Platforms>x86;x64;arm64</Platforms>
<RuntimeIdentifiers>win-x86;win-x64;win-arm64</RuntimeIdentifiers>

would be good

@0x5bfa 0x5bfa mentioned this issue Jun 18, 2024
Closed
@yaira2
Copy link
Member

yaira2 commented Sep 3, 2024

@0x5bfa are we still on board for this? If I recall correctly, this was causing some configuration issues.

@0x5bfa
Copy link
Member Author

0x5bfa commented Sep 3, 2024 •
edited
Loading

Yeah this has great benefits but I think we can slowly adding properties to the shared one, like adding one by one and loading solution step by step on local because I couldn't locate the issue.

@Lamparter Lamparter mentioned this issue Oct 17, 2024
Closed
@Lamparter Lamparter linked a pull request Dec 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Files task board
Status: 🆕 New
Milestone
No milestone
2 participants
@yaira2 @0x5bfa