Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EthGetBlockReceiptsLimited does not use limit #12838

Open
5 of 11 tasks
elmattic opened this issue Jan 21, 2025 · 1 comment
Open
5 of 11 tasks

EthGetBlockReceiptsLimited does not use limit #12838

elmattic opened this issue Jan 21, 2025 · 1 comment
Assignees
Labels
kind/bug Kind: Bug

Comments

@elmattic
Copy link

Checklist

  • This is not a security-related bug/issue. If it is, please follow please follow the security policy.
  • I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
  • I am running the Latest release, the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to lotus.

Lotus component

  • lotus daemon - chain sync
  • lotus fvm/fevm - Lotus FVM and FEVM interactions
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt/WinningPoSt)
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Lotus Version

./lotus version
Daemon:  1.31.0-rc1+calibnet+git.6cd798259.dirty+api1.5.0
Local: lotus version 1.31.0-rc1+calibnet+git.6cd798259.dirty

Repro Steps

  1. Run '...'
  2. Do '...'
  3. See error '...'
    ...

Describe the Bug

https://github.com/filecoin-project/lotus/blob/master/node/impl/eth/transaction.go#L448

Upon reviewing this function's implementation, I noticed that the limit parameter is not being used anywhere.

This is not necessarily a problem, but rather a potential question about what the specification should be.

Logging Information

n/a
@elmattic elmattic added the kind/bug Kind: Bug label Jan 21, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Jan 21, 2025
@rvagg rvagg moved this from 📌 Triage to 🐱 Todo in FilOz Jan 22, 2025
@rvagg rvagg self-assigned this Jan 22, 2025
@rvagg
Copy link
Member

rvagg commented Jan 22, 2025

Whoops! Thanks for picking this up @elmattic; we'll get this done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug
Projects
Status: 🐱 Todo
Development

No branches or pull requests

2 participants