Multiple file upload race condition sorting

[angus-mcritchie]

Package

filament/filament

Package Version

v3.2.132

Laravel Version

v11.37.0

Livewire Version

v3.5.12

PHP Version

8.3.15

Problem description

Upload 2 or more files, the sorting is based on which one uploads first rather than the visible sort order of the uploader.

This happens because FilePond core options default value of maxParallelUploads is 2.

filament-race-sorting.mp4

A simple work around would be allowing to change the maxParallelUploads to 1 and everything would work.

But ideally, we should allow maxParallelUploads to change to more than 1 and still resoect the upload order regardless which file uploads first.

Expected behavior

Select files to upload, order will show 1.svg first, then 2.svg and after upload for them to remain in the same order regardless which one is uploaded first.

Steps to reproduce

clone the reproduction repository
run php artisan migrate
run php artisan db:seed
Login and go to the http://localhost/admin/users/1/edit
Upload 2 or more files (with different file sizes helps reproduce more easily) and see the order change based on which on is uploaded first

Reproduction repository (issue will be closed if this is not valid)

https://github.com/angus-mcritchie/filament-image-race-sorting

Relevant log output

No response

[danharrin]

Thanks for the PR, another setting you can try that affects ordering is appendFiles()

[angus-mcritchie]

Thanks, @danharrin. I have tried the appendFiles() method, but this bug still happens regardless of whether you append or prepend the images. I am confident it's a race condition.

It's especially noticeable when you upload many (like 10 or more) images, and in one case, I had 5 images out of order.

Thanks for merging #15309. Should we keep this open as this is still a bug? The PR adds a workaround.

If I were to make a PR to fix this properly, would you prefer it to be done on v3 or v4?

[danharrin]

Sure, I would accept a PR in v3 since this is a bug

[gcorp-llc]

hi I'm run composer update to project and show error Undefined variable $getMaxParallelUploads for admin panel

[gcorp-llc]

I solved my problem this way.
first remove composer.lock fila and install filament version 3.2.130
composer require filament/filament:"v3.2.130"