Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Blade component children #13730

Closed
zepfietje opened this issue Jul 28, 2024 · 4 comments
Closed

Refactor Blade component children #13730

zepfietje opened this issue Jul 28, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request ui
Milestone

Comments

@zepfietje
Copy link
Member

zepfietje commented Jul 28, 2024

E.g. remove icon prop from button and simply pass an icon component.
Same for dropdown list item badge and probably others.

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
@zepfietje zepfietje added the enhancement New feature or request label Jul 28, 2024
@zepfietje zepfietje added this to the v4 milestone Jul 28, 2024
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Jul 28, 2024
@zepfietje zepfietje self-assigned this Jul 29, 2024
@zepfietje zepfietje added the ui label Jul 29, 2024
@danharrin
Copy link
Member

@zepfietje Can you explain the benefits here please? I think I agree about badges, but I think the icons should remain as they are (I encourage you to take a look at how icons are output in v4 too)

@danharrin
Copy link
Member

Badges refactored in #15506, I can't see other places where this would be useful but open to suggestions.

@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Feb 2, 2025
@zepfietje
Copy link
Member Author

The current system supports only a single icon in a specified position.
Passing an icon element as child of the button component would allow for much more flexible use in Blade and just feels more like HTML.

@danharrin
Copy link
Member

Yeah, there are lots of considerations that would make this tricky though. For example on a button, the icon needs to be replaced with a loading indicator when loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui
Projects
Status: Done
Development

No branches or pull requests

2 participants