Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataset scope should come from dune.dataset_name #58

Open
dougbenjamin opened this issue Jan 9, 2025 · 3 comments
Open

dataset scope should come from dune.dataset_name #58

dougbenjamin opened this issue Jan 9, 2025 · 3 comments

Comments

@dougbenjamin
Copy link

dougbenjamin commented Jan 9, 2025

If dune.dataset_name is defined in the meta data file then get the dataset scope from that variable.

Use the namespace value to define the file scope if defined.

suggested code is in - PR#57

@marcmengel
Copy link
Collaborator

This is ostensibly already implemented in the sample dune module:
https://github.com/fermitools/declad/blob/main/declad/custom/dune.py#L158
Have you updated the custom/dune.py in your configuration?

@marcmengel
Copy link
Collaborator

Nevermind, I wrote the previous before I read the patch.

@dougbenjamin
Copy link
Author

would you kindly create a new tag 2.3.5 and update the version file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants