Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo notebook fails due to recent changes #1

Open
Eisenh opened this issue Jan 31, 2025 · 1 comment
Open

Demo notebook fails due to recent changes #1

Eisenh opened this issue Jan 31, 2025 · 1 comment

Comments

@Eisenh
Copy link

Eisenh commented Jan 31, 2025

I think the recent changes to the feos structure broke this demo. It fails at the imports

from feos.si import *     # SI units and constants
from feos.eos import *    # equation of state objects
from feos.pcsaft import * # parameter objects

And when replaced by
from feos import *
The next cell throws an error:
NameError: name 'SIArray1' is not defined

@g-bauer
Copy link
Contributor

g-bauer commented Feb 6, 2025

Thank you very much for the issue. I'll add an updated version of the notebook when I find the time. Until then you find (hopefully) up-to-date notebooks for FeOs in the examples folder of the main repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants