Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #72 is ok when using solution below, already mentionend by another user. #76

Closed
lvandenb opened this issue Dec 7, 2018 · 2 comments

Comments

@lvandenb
Copy link

lvandenb commented Dec 7, 2018

Solution for me was; like

I just added:

if hasattr(a, 'rev'):
a = a.rev()
b = b.rev()

To the getrange function to check if there is a rev attribute/function that it can call. I am not 100% sure what was getting passed before or if that is sufficient to guard calling the rev method.

@mnauw
Copy link
Contributor

mnauw commented May 31, 2019

As mentioned in #72, these issues are due to changes in recent Mercurial's internal API. They have also been reported as issues in this fork and are already fixed there (along with many other ones), see also generally #69.

@felipec
Copy link
Owner

felipec commented Jun 4, 2019

As mentioned in #72 the fix is commit 00e95fd which is released in v0.4.

@felipec felipec closed this as completed Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@felipec @lvandenb @mnauw and others