diff --git a/.pre-commit-hooks.yaml b/.pre-commit-hooks.yaml index 561920ca31..12c67b927e 100644 --- a/.pre-commit-hooks.yaml +++ b/.pre-commit-hooks.yaml @@ -1,5 +1,5 @@ - id: cfn-python-lint - name: AWSLabs CloudFormation Linter + name: AWS CloudFormation Linter entry: cfn-lint language: python files: \.(json|yaml|yml)$ diff --git a/CHANGELOG.md b/CHANGELOG.md index 32b024b93d..f805f8e215 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,7 +12,7 @@ ### 0.15.0 ###### Features - Add scaffolding for arbitrary Match attributes, adding attributes for Type checks -- Add rule [E3024](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3024) to validate that ProvisionedThroughput is not specified with BillingMode PAY_PER_REQUEST +- Add rule [E3024](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3024) to validate that ProvisionedThroughput is not specified with BillingMode PAY_PER_REQUEST ###### CloudFormation Specifications - Update Spec files to 2.24.0 - Update OnlyOne spec to have BlockDeviceMapping to include NoDevice with Ebs and VirtualName @@ -20,8 +20,8 @@ - Add all the allowed values of the AWS::DAX::* Resources ###### Fixes - Update config parsing to use the builtin Yaml decoder -- Add condition support for Inclusive [E2521](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2521), Exclusive [E2520](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2520), and AtLeastOne [E2522](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2522) rules -- Update rule [E1029](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1029) to better check Resource strings inside IAM Policies +- Add condition support for Inclusive [E2521](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2521), Exclusive [E2520](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2520), and AtLeastOne [E2522](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2522) rules +- Update rule [E1029](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1029) to better check Resource strings inside IAM Policies - Improve the line/column information of a Match with array support @@ -32,21 +32,21 @@ - Add allowed values for AWS::ServiceDiscovery::* resources - Fix allowed values for Apache MQ ###### Fixes -- Update rule [E3008](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3008) to not error when using a list from a custom resource +- Update rule [E3008](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3008) to not error when using a list from a custom resource - Support simple types in the CloudFormation spec - Add tests for the formatters ### 0.14.0 ###### Features -- Add rule [E3035](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3035) to check the values of DeletionPolicy -- Add rule [E3036](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3036) to check the values of UpdateReplacePolicy -- Add rule [E2014](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2014) to check that there are no REFs in the Parameter section -- Update rule [E2503](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2503) to support TLS on NLBs +- Add rule [E3035](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3035) to check the values of DeletionPolicy +- Add rule [E3036](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3036) to check the values of UpdateReplacePolicy +- Add rule [E2014](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2014) to check that there are no REFs in the Parameter section +- Update rule [E2503](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2503) to support TLS on NLBs ###### CloudFormation Specifications - Update CloudFormation spec to version 2.22.0 - Add allowed values for AWS::Cognito::* resources ###### Fixes -- Update rule [E3002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3002) to allow GetAtts to Custom Resources under a Condition +- Update rule [E3002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3002) to allow GetAtts to Custom Resources under a Condition ### 0.13.2 ###### Features @@ -66,11 +66,11 @@ ### 0.13.0 ###### Features -- New rule [W1011](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W1011) to check if a FindInMap is using the correct map name and keys -- New rule [W1001](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W1001) to check if a Ref/GetAtt to a resource that exists when Conditions are used -- Removed logic in [E1011](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1011) and moved it to [W1011](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W1011) for validating keys +- New rule [W1011](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W1011) to check if a FindInMap is using the correct map name and keys +- New rule [W1001](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W1001) to check if a Ref/GetAtt to a resource that exists when Conditions are used +- Removed logic in [E1011](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1011) and moved it to [W1011](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W1011) for validating keys - Add property relationships for AWS::ApplicationAutoScaling::ScalingPolicy into Inclusive, Exclusive, and AtLeastOne -- Update rule [E2505](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2505) to check the netmask bit +- Update rule [E2505](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2505) to check the netmask bit - Include the ability to update the CloudFormation Specs using the Pricing API ###### CloudFormation Specifications - Update to version 2.21.0 @@ -84,23 +84,23 @@ - Add allowed values for RDS InstanceTypes from pricing API ###### Fixes - Fixed README indentation issue with .pre-commit-config.yaml -- Fixed rule [E2541](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2541) to allow for multiple inputs/outputs in a CodeBuild task -- Fixed rule [E3020](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3020) to allow for a period or no period at the end of a ACM registration record -- Update rule [E3001](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3001) to support UpdateReplacePolicy +- Fixed rule [E2541](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2541) to allow for multiple inputs/outputs in a CodeBuild task +- Fixed rule [E3020](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3020) to allow for a period or no period at the end of a ACM registration record +- Update rule [E3001](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3001) to support UpdateReplacePolicy - Fix a cli issue where `--template` wouldn't be used when a .cfnlintrc was in the same folder -- Update rule [E3002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3002) and [E1024](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W3002) to support packaging of AWS::Lambda::LayerVersion content +- Update rule [E3002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3002) and [E1024](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W3002) to support packaging of AWS::Lambda::LayerVersion content ### 0.12.1 ###### CloudFormation Specifications - Add AWS::WorkSpaces::Workspace.WorkspaceProperties ComputeTypeName, RunningMode allowed values - Fix AWS::CloudWatch::Alarm to point Metrics at AWS::CloudWatch::Alarm.MetricDataQuery ###### Fixes -- Update rule [E1024](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1024) to support Fn::Sub inside Fn::Cidr +- Update rule [E1024](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1024) to support Fn::Sub inside Fn::Cidr ### 0.12.0 ###### Features -- Update rule [E1019](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1019) to not allow for lists directly when doing a Ref or GetAtt to a list -- Move parameter checks from rule [E3030](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3030) to a new rule [W2030](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W2030) +- Update rule [E1019](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1019) to not allow for lists directly when doing a Ref or GetAtt to a list +- Move parameter checks from rule [E3030](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3030) to a new rule [W2030](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W2030) ###### CloudFormation Specifications - Updated to version 2.19.0 - Add S3 Bucket Allowed Values @@ -110,7 +110,7 @@ - Add AWS::SES::ReceiptRule.Rule TlsPolicy Allowed Values - Add AWS::AutoScaling::AutoScalingGroup, AWS::Route53::RecordSetGroup, and AWS::AutoScaling::AutoScalingGroup to OnlyOne ###### Fixes -- Improve [W7001](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W7001) error message +- Improve [W7001](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W7001) error message ### 0.11.1 ###### CloudFormation Specifications @@ -118,18 +118,18 @@ - AWS::Batch::ComputeEnvironment InstanceRole is an InstanceProfile not Role ###### Fixes - Add debug options to print a stack trace for rule E0002 -- Update rule [E2015](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2015) to include a try/catch around AllowedPattern testing to catch errors caused by non Python supported regex +- Update rule [E2015](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2015) to include a try/catch around AllowedPattern testing to catch errors caused by non Python supported regex ### 0.11.0 ###### Features -- Add rule [E3030](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3030) to use the newly patched spec to check resource properties values. Update the following rules replaced by [E3030](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3030). - - Delete rule [W2512](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W2512) - - Delete rule [E2531](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2531) - - Move allowed values check in rule [E2505](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2505) -- Add rule [E3008](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3008) to use the newly patched spec to check a resource properties Ref and GetAtt. Update the following rules replaced by [E3008](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3008). - - Delete rule [E2502](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2502) - - Delete rule [W2505](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W2505) -- Improve rule [E3020](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3020) to check MX records +- Add rule [E3030](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3030) to use the newly patched spec to check resource properties values. Update the following rules replaced by [E3030](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3030). + - Delete rule [W2512](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W2512) + - Delete rule [E2531](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2531) + - Move allowed values check in rule [E2505](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2505) +- Add rule [E3008](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3008) to use the newly patched spec to check a resource properties Ref and GetAtt. Update the following rules replaced by [E3008](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3008). + - Delete rule [E2502](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2502) + - Delete rule [W2505](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W2505) +- Improve rule [E3020](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3020) to check MX records ###### CloudFormation Specifications - Update CloudFormation specs to 2.18.1 - Append the CloudFormation spec to include: @@ -140,9 +140,9 @@ - Add `AWS::CloudWatch::Alarm.Metric`, `AWS::CloudWatch::Alarm.MetricDataQuery` and `AWS::CloudWatch::Alarm.MetricStat` in all supported regions - Add `AWS::Lambda::LayerVersion`, `AWS::Lambda::LayerVersion.Content`, and `AWS::Lambda::LayerVersionPermission` in all supported regions ###### Fixes -- Fix description on rule [W2501](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W2501) to be more informative -- Update rule [E2532](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2532) to allow `Parameters` in a `Task` in a Step Function -- Fix rule [E1010](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1010) to allow Refs in the GetAtt attribute section +- Fix description on rule [W2501](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W2501) to be more informative +- Update rule [E2532](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2532) to allow `Parameters` in a `Task` in a Step Function +- Fix rule [E1010](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1010) to allow Refs in the GetAtt attribute section - Add `AWS::CloudFormation::Init` as an exception for rule E1029 - Add `Informational` error messages to JSON outputs - Fix file searching `**/*` to recursively search in Python 3.5 and greater @@ -153,15 +153,15 @@ - Code coverage testing integrated into the CI process - Update CloudFormation specs to 2.18.0 ###### Fixes -- Fix rule [E2505](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2505) to allow for SSM parameters when checking Cidr and Tenancy parameters -- Fix rule [E1029](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1029) to not error on API Gateway stageVariables +- Fix rule [E2505](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2505) to allow for SSM parameters when checking Cidr and Tenancy parameters +- Fix rule [E1029](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1029) to not error on API Gateway stageVariables ### 0.10.1 ###### Features - Support stdin for reading and testing templates ###### Fixes - Remove dependency on regex package as it requires gcc -- Remove rule [E3507](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3507) because it depends on regex package +- Remove rule [E3507](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3507) because it depends on regex package ### 0.10.0 ###### Features @@ -171,9 +171,9 @@ - Update aws-sam-translator to v1.8.0 - Update requests dependency to be at least version 2.15.0 - Add Python 3.7 support for Lambda -- Provide valid Python runtimes in rule [E2531](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2531) error message -- Allow Fn::Sub inside a Fn::Sub for rule [E1019](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1019) -- Add hardcoded list check as invalid in rule [E6003](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E6003) +- Provide valid Python runtimes in rule [E2531](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2531) error message +- Allow Fn::Sub inside a Fn::Sub for rule [E1019](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1019) +- Add hardcoded list check as invalid in rule [E6003](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E6003) - Fix home expansion with when looking for .cfnlintrc in Python 3.4 - Add testing in Travis for Py34, Py35, Py37 - Prevent spaces after the comma in spec file @@ -183,9 +183,9 @@ ###### Features - Update specs to version 2.15.0 ###### Fixes -- Fix rule [E3020](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3020) to allow multiple text records of up to 255 characters -- Fix rule [E3016](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3020) to handle conditions in Update Policies -- Fix rule [E2532](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2532) to not fail when using a Fn::Sub and a number for a param +- Fix rule [E3020](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3020) to allow multiple text records of up to 255 characters +- Fix rule [E3016](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3020) to handle conditions in Update Policies +- Fix rule [E2532](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2532) to not fail when using a Fn::Sub and a number for a param ### 0.9.1 ###### Features @@ -196,21 +196,21 @@ - Add Custom Error for when trying to access an attribute in the classes that make up the template - Fix an issue with deepcopy not creating copies with start and end marks - Fix 4 rules that would fail when trying to create the path of the error and running into an integer -- Fix rule [E2015](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2015) to force parameter default values to be a string when testing against the AllowedPattern regex pattern +- Fix rule [E2015](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2015) to force parameter default values to be a string when testing against the AllowedPattern regex pattern - Fix a bug in the config engine in which append rules would have gone to override spec - Remove exit calls from functions that are used in integrations preventing pre-mature failures -- Fix rule [E3002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3002) [E3003](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3003) to support functions that may be able to support objects +- Fix rule [E3002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3002) [E3003](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3003) to support functions that may be able to support objects ### 0.9.0 ###### Features -- Add rule [E8002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E8002) to validate if resource Conditions or Fn::If conditions are defined -- Improve rule [E3002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3002) to validate custom resources when custom specs are addended to the resource spec using override-spec +- Add rule [E8002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E8002) to validate if resource Conditions or Fn::If conditions are defined +- Improve rule [E3002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3002) to validate custom resources when custom specs are addended to the resource spec using override-spec - Allow for configuration of cfn-lint using configuration files in the project and home folder called .cfnlintrc - Updated specs to versions release 2.12.0 ###### Fixes -- Fix rule [E3002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3002) to not fail when looking for lists of objects and using a FindInMap or GetAtt to a custom resource as both could suppliy a list of objects -- Remove rule [E1025](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1025) which was duplicative to the more extensive rule E8002 -- Fix rule [E3020](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3020) to allow for quotes when checking the length +- Fix rule [E3002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3002) to not fail when looking for lists of objects and using a FindInMap or GetAtt to a custom resource as both could suppliy a list of objects +- Remove rule [E1025](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1025) which was duplicative to the more extensive rule E8002 +- Fix rule [E3020](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3020) to allow for quotes when checking the length - Add generic exception handling to SAM transforming functions - Complete redo how we handle arguments to fix issues created when linting multiple files with cfn-lint configurations in the file - New CloudFormation spec patch to not require CidrBlock on resource type AWS::EC2::NetworkAclEntry @@ -219,35 +219,35 @@ ### 0.8.3 ###### Features -- Add rule [E3022](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3022) to validate that there is only one SubnetRouteTableAssociation per subnet +- Add rule [E3022](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3022) to validate that there is only one SubnetRouteTableAssociation per subnet ###### Fixes -- Fix rule [E2502](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2502) to check Arn and Name for AWS::EC2::LaunchTemplate resources -- Fix rule [E3016](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3016) to remove use of Path which may not be defined in certain scenarios +- Fix rule [E2502](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2502) to check Arn and Name for AWS::EC2::LaunchTemplate resources +- Fix rule [E3016](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3016) to remove use of Path which may not be defined in certain scenarios - Fix base rule Class so that resource_property_types and resource_sub_property_types is initialized from on every new rule and not copied from previous rules that were initialized - Fix conversions of transformed templates in which keys stayed as str(s) instead of str_node(s) ### 0.8.2 ###### Fixes -- Update rule [E2502](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2502) to allow GetAtt against a nested stack or custom resource -- Update rules [E2541](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2541) and [E2540](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2540) to support conditions inside the CodePipeline -- Fix types in rule [E2532](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2532) to now include InputPath and OutputPath -- Update rule [E1029](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1029) to skip missing sub when looking at parameters in IAM policies -- Update rule [E2507](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2507) to allow for strings in the IAM policy -- Update rule [E2507](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2507) to allow the policy statement to be an object along with a list +- Update rule [E2502](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2502) to allow GetAtt against a nested stack or custom resource +- Update rules [E2541](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2541) and [E2540](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2540) to support conditions inside the CodePipeline +- Fix types in rule [E2532](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2532) to now include InputPath and OutputPath +- Update rule [E1029](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1029) to skip missing sub when looking at parameters in IAM policies +- Update rule [E2507](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2507) to allow for strings in the IAM policy +- Update rule [E2507](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2507) to allow the policy statement to be an object along with a list ### 0.8.1 ###### Features - Update Specs to the versions released October 19th, 2018 ###### Fixes -- Fix rule [E2541](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2541) to not fail on non-string values +- Fix rule [E2541](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2541) to not fail on non-string values ### 0.8.0 ###### Features - Created a process to patch the CloudFormation Spec and patched a bunch of issues - Support pre-commit hooks for linting templates -- Add rule [E3021](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3021) to that 5 or less targets are added to a CloudWatch Event -- Add rule [E1029](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1029) to look for Sub variables that aren't inside a Sub -- Add rule [I3011](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#I3011) to validate that DynamDB Tables have deletion policy specified as the default is to delete the database. +- Add rule [E3021](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3021) to that 5 or less targets are added to a CloudWatch Event +- Add rule [E1029](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1029) to look for Sub variables that aren't inside a Sub +- Add rule [I3011](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#I3011) to validate that DynamDB Tables have deletion policy specified as the default is to delete the database. - Add support for `info` errors ###### Fixes - Update search_deep_keys to look for items in the Global section which is lost in a Transformation @@ -256,29 +256,29 @@ ### 0.7.4 ###### Features - Support parsing multiple files from the command line -- New rule [E3016](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3016) to validate a resources UpdatePolicy configuration +- New rule [E3016](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3016) to validate a resources UpdatePolicy configuration ###### Fixes -- Removes sub parameter check from rule [E1012](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1012). The same check is covered by -[E1019](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1019) -- Fix rule [E1010](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1010) when using a string not an array with Fn::Sub -- Fix rule [E3020](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3020) ignore intrinsic functions when checking values +- Removes sub parameter check from rule [E1012](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1012). The same check is covered by +[E1019](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1019) +- Fix rule [E1010](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1010) when using a string not an array with Fn::Sub +- Fix rule [E3020](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3020) ignore intrinsic functions when checking values ### 0.7.3 ###### Features - Update the custom objects for the template to directly allow the calling of getting items and checking items that is condition safe - Update CloudFormation Specs to 2018-09-21 released specs ###### Fixes -- Fix rule [E2540](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2540) to not fail when the stage names aren't strings -- Fix rule [E3002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3002) to not fail when processing Ref AWS::NoValue +- Fix rule [E2540](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2540) to not fail when the stage names aren't strings +- Fix rule [E3002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3002) to not fail when processing Ref AWS::NoValue - Core functionality updated to fail when extending rules directory doesn't exist -- Fix rule [E3002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3002) metadata isn't supported as a resource property -- Fix rule [E2509](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2509) to not error when using a function for description +- Fix rule [E3002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3002) metadata isn't supported as a resource property +- Fix rule [E2509](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2509) to not error when using a function for description ### 0.7.2 ###### Fixes -- Fix rule [W2501](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W2501) to support dashes in KMS Key name -- Fix rule [E2543](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2543) to not fail when the type of a step isn't known -- Fix rule [E2507](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2507) to have an exception for ECR Policies. Resource isn't required. +- Fix rule [W2501](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W2501) to support dashes in KMS Key name +- Fix rule [E2543](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2543) to not fail when the type of a step isn't known +- Fix rule [E2507](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2507) to have an exception for ECR Policies. Resource isn't required. - Several Python cleanup items around initializing lists, how version is loaded, and dropping 'discover' in testing ### 0.7.1 @@ -287,16 +287,16 @@ ### 0.7.0 ###### Features -- New Rule [W1019](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W1019) to make sure any Sub variables are used in the string -- New Rule [E2532](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2532) to start basic validation of state machine syntax -- New Rule [W1020](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W1020) to see if Sub is needed and variables are being used -- New Rule [E1028](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1028) validate that first element in a Fn::If array is a string -- New Rule [W3002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W3002) to warn when templated templates are used -- Update Rule [E2507](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2507) to check resource base policies -- Add Rule [W2511](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W2511) to warn when using an older version of IAM Policy Version +- New Rule [W1019](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W1019) to make sure any Sub variables are used in the string +- New Rule [E2532](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2532) to start basic validation of state machine syntax +- New Rule [W1020](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W1020) to see if Sub is needed and variables are being used +- New Rule [E1028](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1028) validate that first element in a Fn::If array is a string +- New Rule [W3002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W3002) to warn when templated templates are used +- Update Rule [E2507](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2507) to check resource base policies +- Add Rule [W2511](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W2511) to warn when using an older version of IAM Policy Version ###### Fixes -- Update Rule [E3002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3002) to allow for templated code -- Update Rule [E1024](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1024) to allow Cidr function to use GetAtt +- Update Rule [E3002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3002) to allow for templated code +- Update Rule [E1024](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1024) to allow Cidr function to use GetAtt - Fix core functionality to not error if the template is an array or string instead of an object ### 0.6.1 @@ -306,46 +306,46 @@ ### 0.6.0 ###### Features - Update formatters to be similar from JSON and text outputs and modularize for easier growth later -- Don't raise an error with [E3020](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3020) when doing ACM DNS validation registration -- Add rule [E7003](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E7003) to validate that mapping keys are strings. -- Add rule [E1027](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1027) to validate that dynamic reference secure strings are to supported properties -- Add rule [E1004](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1004) to validate that the Template Description is only a string -- Add rule [E6005](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E6005) to validate that an Output Description is only a string -- Add rule [E6012](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E6005) to validate that an Output Description is less than the maximum length +- Don't raise an error with [E3020](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3020) when doing ACM DNS validation registration +- Add rule [E7003](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E7003) to validate that mapping keys are strings. +- Add rule [E1027](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1027) to validate that dynamic reference secure strings are to supported properties +- Add rule [E1004](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1004) to validate that the Template Description is only a string +- Add rule [E6005](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E6005) to validate that an Output Description is only a string +- Add rule [E6012](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E6005) to validate that an Output Description is less than the maximum length ###### Fixes - Fix core libraries to handle conditions around resource properties so that the resource and property checks still run - Fix core libraries to handle the special property type `Tag` so that its checked when a rule is doing a Property Check ### 0.5.2 ###### Fixes -- Support additional attributes in spec file for [E3002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3003) -- Check custom resources as if they are 'AWS::CloudFormation::CustomResource' in rule [E3003](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3003) -- Fix [W6001](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W6001) when an ImportValue is used to another function -- Fix [W2501](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W2501) to support the new dynamic reference feature +- Support additional attributes in spec file for [E3002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3003) +- Check custom resources as if they are 'AWS::CloudFormation::CustomResource' in rule [E3003](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3003) +- Fix [W6001](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W6001) when an ImportValue is used to another function +- Fix [W2501](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W2501) to support the new dynamic reference feature ### 0.5.1 ###### Features -- Update rule [E3020](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3020) to support CAA and CNAME record checks +- Update rule [E3020](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3020) to support CAA and CNAME record checks - Update specs to ones released on August 16, 2018 ### 0.5.0 ###### Features - Load all instances of CloudFormationLintRule in a file. Class doesn't need to match the filename anymore - Allow load yaml to accept a string allowing people to use cfn-lint as a module -- Add rule [W6001](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W6001) to test outputs that are just using an import value +- Add rule [W6001](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W6001) to test outputs that are just using an import value - Update specs to ones released on August 10, 2018 ###### Fixes -- Update [E2507](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2507) to support conditions and using get_values to test all condition paths -- Update [E2521](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2521), [E2523](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2523) to support conditions and using get_values to test all condition paths -- Rewrite [E2503](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2503) to support intrinsic functions and conditions and lower case protocols -- Fix [E1018](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1018) to support Sub inside a Split function -- Fix [E3003](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3003) description messages to be more informative -- Fix [E3001](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3001) to not require parameters when CreationPolicy is used +- Update [E2507](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2507) to support conditions and using get_values to test all condition paths +- Update [E2521](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2521), [E2523](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2523) to support conditions and using get_values to test all condition paths +- Rewrite [E2503](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2503) to support intrinsic functions and conditions and lower case protocols +- Fix [E1018](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1018) to support Sub inside a Split function +- Fix [E3003](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3003) description messages to be more informative +- Fix [E3001](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3001) to not require parameters when CreationPolicy is used - Fix SAM region when no region is available from a local AWS profile or environment variable. ### 0.4.2 ###### Features -- Update rule [E3020](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3020) to support AAAA record checks +- Update rule [E3020](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3020) to support AAAA record checks ###### Fixes - Fix many rules that would fail if a sub parameter had a space at the beginning or end - Fix crashing issues when trying to get resources that aren't properly configured @@ -364,29 +364,29 @@ ###### Fixes - Fix a bunch of typos across many different rules - Support DeepCopy with Template and custom String classes used for marking up templates -- Fix Rule [E3002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3002) to support CommaDelimitedList when looking for List Parameters +- Fix Rule [E3002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3002) to support CommaDelimitedList when looking for List Parameters - Fix core engine to check that something is a Dict instead of assuming it is ### 0.3.5 ###### Features - Update CloudFormation Specs to July 12th, 2018 -- Rule [E7012](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E7012) added to check the limits of attributes in a Mapping -- Rule [E2012](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2012) added to check maximum size of a parameter value -- Rule [E1003](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1003) added to check the maximum length of the template Description +- Rule [E7012](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E7012) added to check the limits of attributes in a Mapping +- Rule [E2012](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2012) added to check maximum size of a parameter value +- Rule [E1003](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1003) added to check the maximum length of the template Description - Guide created to help new users write new rules ###### Fixes - Catch KeyError when trying to discover the line and column number of an error - Update Lambda rules to support dotnet core -- Fix rule [E1017](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1017) so we unpack first element of select as a dict -- Fix rule [E1024](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1024) to support ImportValue and appropriately checking number for the last element +- Fix rule [E1017](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1017) so we unpack first element of select as a dict +- Fix rule [E1024](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1024) to support ImportValue and appropriately checking number for the last element ### 0.3.3 ###### Features - Support for Yaml C Parser when available. - Catch rule processing errors and raise a lint error in their place. - Add rules for the limit on Parameter, Mapping, Resource and Output names -- Add Rule [W3005](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W3005) to warn for when DependsOn is specified but not needed -- Add Rule [E2509](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2509) to check if Security Group Descriptions are properly configured +- Add Rule [W3005](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W3005) to warn for when DependsOn is specified but not needed +- Add Rule [E2509](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2509) to check if Security Group Descriptions are properly configured - Add `source_url` to rules so rule reference documentation can be provided ###### Fixes - Fixed issues when Conditions had lists for values @@ -402,24 +402,24 @@ ### 0.3.1 ###### Features -- Update rule [E3020](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3020) to validate A recordsets +- Update rule [E3020](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3020) to validate A recordsets ###### Fixes - Require "aws-sam-translator" dependency be at least 1.6.0 -- Add support for wildcards in rule [E3013](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3013) - Support conditions in Lists for rule [E3002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3002) - Include filename when we run into Null and Duplicate values when parsing yaml +- Add support for wildcards in rule [E3013](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3013) - Support conditions in Lists for rule [E3002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3002) - Include filename when we run into Null and Duplicate values when parsing yaml - Rule W2510 now allows for AllowedValues instead of just Min/MaxValue for compliance of Lambda MemorySize -- Rule [E2530](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2530) updated to checked AllowedValues for compliance of Lambda MemorySize +- Rule [E2530](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2530) updated to checked AllowedValues for compliance of Lambda MemorySize ### 0.3.0 ###### Features - Serverless Transforms now handled by SAM libraries -- Add Rule [E2508](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2508): Add checks for IAM +- Add Rule [E2508](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2508): Add checks for IAM - Managed Policies attached to IAM user, group or role can't be more than 10 - An IAM user can be a member of no more than 10 groups - There can only be 1 role in an instance profile - AssumeRolePolicyDocument size is less than <2048 characters -- Add Rule [E1002](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1002): Check overall template size to make sure its below -- Add Rule [E3013](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3013): CloudFront aliases should contain valid domain names -- Add Rule [E3020](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3020): Check if all RecordSets are correctly configured +- Add Rule [E1002](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1002): Check overall template size to make sure its below +- Add Rule [E3013](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3013): CloudFront aliases should contain valid domain names +- Add Rule [E3020](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3020): Check if all RecordSets are correctly configured - Strings end and start with double quotes - Size is less than 256 characters - Record Types are within the specification @@ -438,24 +438,24 @@ ### 0.2.1 ###### Features - Added AllowedValues for Cidr parameter checking Rule W2509 -- Add Rule [E2004](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E2004) to check Allowed values for Cidr parameters are a valid Cidr range -- Disable mapping Name checks [W7001](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#W7001) if dynamic mapping names are used (Ref, FindInMap) -- New Rule [E1026](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1026) to make sure Ref's in 'Conditions' are to parameters and not resources +- Add Rule [E2004](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E2004) to check Allowed values for Cidr parameters are a valid Cidr range +- Disable mapping Name checks [W7001](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#W7001) if dynamic mapping names are used (Ref, FindInMap) +- New Rule [E1026](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1026) to make sure Ref's in 'Conditions' are to parameters and not resources - Updated CloudFormation specs to June 5th, 2018 ###### Fixes -- Fixed an issue with Rule [E1019](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E1019) not giving errors when there was a bad pseudo parameter +- Fixed an issue with Rule [E1019](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E1019) not giving errors when there was a bad pseudo parameter - Fixed an issue where conditions with Refs were validated as strings instead of Refs - Fix crash errors when an empty yaml file is provided - Updated condition functions to return the full object (Ref isn't translated while looking for AWS::NoValue) -- Support Map Type properties when doing PrimitiveType check [E3012](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3012) - Fix an issue when boolean values not being checked when using check_value +- Support Map Type properties when doing PrimitiveType check [E3012](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3012) - Fix an issue when boolean values not being checked when using check_value ### 0.2.0 ###### Features -- Standard cfn-lint Errors ([E0000](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E0000)) for null, duplicate, and parse errors +- Standard cfn-lint Errors ([E0000](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E0000)) for null, duplicate, and parse errors - Add a new check for CloudFormation limits - Add a new check for Parameter, Resource, Output, and Mapping names - Update specs to those released on May 25th, 2018 -- Strong type checking for property values result in Errors ([E3012](https://github.com/awslabs/cfn-python-lint/blob/master/docs/rules.md#E3012)) +- Strong type checking for property values result in Errors ([E3012](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/rules.md#E3012)) ###### Fixes - Transform logic updated to not add a Role if one is specified for a serverless function - Fixed logic around Fn::If when the result is an object diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 69afd66d16..b56dd40dc6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,9 +1,9 @@ # Contributing Guidelines -Thank you for your interest in contributing to our project. Whether it's a bug report, new feature, correction, or additional +Thank you for your interest in contributing to our project. Whether it's a bug report, new feature, correction, or additional documentation, we greatly value feedback and contributions from our community. -Please read through this document before submitting any issues or pull requests to ensure we have all the necessary +Please read through this document before submitting any issues or pull requests to ensure we have all the necessary information to effectively respond to your bug report or contribution. @@ -11,7 +11,7 @@ information to effectively respond to your bug report or contribution. We welcome you to use the GitHub issue tracker to report bugs or suggest features. -When filing an issue, please check [existing open](https://github.com/awslabs/python-cfn-lint/issues), or [recently closed](https://github.com/awslabs/python-cfn-lint/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), issues to make sure somebody else hasn't already +When filing an issue, please check [existing open](https://github.com/aws-cloudformation/cfn-python-lint/issues), or [recently closed](https://github.com/aws-cloudformation/cfn-python-lint/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), issues to make sure somebody else hasn't already reported the issue. Please try to include as much information as you can. Details like these are incredibly useful: * A reproducible test case or series of steps @@ -36,17 +36,17 @@ To send us a pull request, please: 5. Send us a pull request, answering any default questions in the pull request interface. 6. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation. -GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and +GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and [creating a pull request](https://help.github.com/articles/creating-a-pull-request/). ## Finding contributions to work on -Looking at the existing issues is a great way to find something to contribute on. As our projects, by default, use the default GitHub issue labels ((enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at any ['help wanted'](https://github.com/awslabs/python-cfn-lint/labels/help%20wanted) issues is a great place to start. +Looking at the existing issues is a great way to find something to contribute on. As our projects, by default, use the default GitHub issue labels ((enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at any ['help wanted'](https://github.com/aws-cloudformation/cfn-python-lint/labels/help%20wanted) issues is a great place to start. ## Code of Conduct -This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct). -For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact +This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct). +For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact opensource-codeofconduct@amazon.com with any additional questions or comments. @@ -56,6 +56,6 @@ If you discover a potential security issue in this project we ask that you notif ## Licensing -See the [LICENSE](https://github.com/awslabs/python-cfn-lint/blob/master/LICENSE) file for our project's licensing. We will ask you to confirm the licensing of your contribution. +See the [LICENSE](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/LICENSE) file for our project's licensing. We will ask you to confirm the licensing of your contribution. We may ask you to sign a [Contributor License Agreement (CLA)](http://en.wikipedia.org/wiki/Contributor_License_Agreement) for larger changes. diff --git a/README.md b/README.md index f82f4136aa..e803072442 100644 --- a/README.md +++ b/README.md @@ -1,10 +1,10 @@ # CloudFormation Linter -[cfn-lint logo] +[cfn-lint logo] -[![Build Status](https://travis-ci.com/awslabs/cfn-python-lint.svg?branch=master)](https://travis-ci.com/awslabs/cfn-python-lint) +[![Build Status](https://travis-ci.com/aws-cloudformation/cfn-python-lint.svg?branch=master)](https://travis-ci.com/aws-cloudformation/cfn-python-lint) [![PyPI version](https://badge.fury.io/py/cfn-lint.svg)](https://badge.fury.io/py/cfn-lint) -[![codecov](https://codecov.io/gh/awslabs/cfn-python-lint/branch/master/graph/badge.svg)](https://codecov.io/gh/awslabs/cfn-python-lint) +[![codecov](https://codecov.io/gh/aws-cloudformation/cfn-python-lint/branch/master/graph/badge.svg)](https://codecov.io/gh/aws-cloudformation/cfn-python-lint) Validate CloudFormation yaml/json templates against the CloudFormation spec and additional checks. Includes checking valid values for resource properties and best practices. @@ -167,7 +167,7 @@ If you'd like cfn-lint to be run automatically when making changes to files in y ```yaml repos: -- repo: https://github.com/awslabs/cfn-python-lint +- repo: https://github.com/aws-cloudformation/cfn-python-lint rev: v0.15.0 # The version of cfn-lint to use hooks: - id: cfn-python-lint @@ -175,7 +175,7 @@ repos: ``` * If you exclude the `files:` line above, every json/yml/yaml file will be checked. -* You can see available cfn-lint versions on the [releases page](https://github.com/awslabs/cfn-python-lint/releases). +* You can see available cfn-lint versions on the [releases page](https://github.com/aws-cloudformation/cfn-python-lint/releases). ---- **PyPi:** diff --git a/docs/cfn-resource-specification.md b/docs/cfn-resource-specification.md index 499f826874..f38dd05dcc 100644 --- a/docs/cfn-resource-specification.md +++ b/docs/cfn-resource-specification.md @@ -12,7 +12,7 @@ The Required rule ([`E3003`](/docs/rules.md#E3003)) checks if properties that ar ### ValuePrimitiveType The ValuePrimitiveType rule ([`E3012`](/docs/rules.md#E3012)) checks if the value of a property is of the same type as specified in the [property specifications](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification-format.html#cfn-resource-specification-format-propertytypes) thus enforcing strict typing of CloudFormation templates. In short this means a number is a number, string is a string, etc. -Although there are situations in which a warning would be sufficient (Python/YAML does implicit conversions) this could also result in errors (More information in issues [42](https://github.com/awslabs/cfn-python-lint/issues/42) and [180](https://github.com/awslabs/cfn-python-lint/issues/180)). Since the Specification contains a mapping to the underlying API's this is out of control of cfn-lint. cfn-lint doesn't have an exception process so all instances of this issue are considered errors. +Although there are situations in which a warning would be sufficient (Python/YAML does implicit conversions) this could also result in errors (More information in issues [42](https://github.com/aws-cloudformation/cfn-python-lint/issues/42) and [180](https://github.com/aws-cloudformation/cfn-python-lint/issues/180)). Since the Specification contains a mapping to the underlying API's this is out of control of cfn-lint. cfn-lint doesn't have an exception process so all instances of this issue are considered errors. ### Properties The Properties rule ([`E3002`](/docs/rules.md#E3002)) checks if the basic property configuration of resources is correct. It checks the properties from the [Resource Specification](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification-format.html#cfn-resource-specification-format-resourcetype) and [property specifications](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification-format.html#cfn-resource-specification-format-propertytypes) to check if the specified properties are valid and performs basic checks on the Type (e.g. sub-properties and Lists). diff --git a/docs/rules.md b/docs/rules.md index 592868d76f..18427d095a 100644 --- a/docs/rules.md +++ b/docs/rules.md @@ -36,7 +36,7 @@ The following **104** rules are applied by this linter: | E0000 | Parsing error found when parsing the template | Checks for Null values and Duplicate values in resources | [Source]() | `base` | | E0001 | Error found when transforming the template | Errors found when performing transformation on the template | [Source]() | `base`,`transform` | | E0002 | Error processing rule on the template | Errors found when processing a rule on the template | [Source]() | `base`,`rule` | -| E1001 | Basic CloudFormation Template Configuration | Making sure the basic CloudFormation template components are properly configured | [Source](https://github.com/awslabs/cfn-python-lint) | `base` | +| E1001 | Basic CloudFormation Template Configuration | Making sure the basic CloudFormation template components are properly configured | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `base` | | E1002 | Template size limit | Check the size of the template is less than the upper limit | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cloudformation-limits.html) | `limits` | | E1003 | Template description limit | Check if the size of the template description is less than the upper limit | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cloudformation-limits.html) | `limits` | | E1004 | Template description can only be a string | Template description can only be a string | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/template-description-structure.html) | `description` | @@ -74,24 +74,24 @@ The following **104** rules are applied by this linter: | E2508 | Check IAM resource limits | See if IAM resources do not breach limits | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cloudformation-limits.html) | `resources`,`iam` | | E2509 | Validate SecurityGroup description | Check if SecurityGroup descriptions are correctly configured | [Source](https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateSecurityGroup.html) | `resources`,`securitygroup` | | E2510 | Resource EC2 PropertiesEc2Subnet Properties | See if EC2 Subnet Properties are set correctly | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-subnet.html) | `properties`,`subnet` | -| E2520 | Check Properties that are mutually exclusive | Making sure CloudFormation properties that are exclusive are not defined | [Source](https://github.com/awslabs/cfn-python-lint) | `resources` | -| E2521 | Check Properties that are required together | Make sure CloudFormation resource properties are included together when required | [Source](https://github.com/awslabs/cfn-python-lint) | `resources` | -| E2522 | Check Properties that need at least one of a list of properties | Making sure CloudFormation properties that require at least one property from a list. More than one can be included. | [Source](https://github.com/awslabs/cfn-python-lint) | `resources` | -| E2523 | Check Properties that need only one of a list of properties | Making sure CloudFormation properties that require only one property from a list. One has to be specified. | [Source](https://github.com/awslabs/cfn-python-lint) | `resources` | +| E2520 | Check Properties that are mutually exclusive | Making sure CloudFormation properties that are exclusive are not defined | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `resources` | +| E2521 | Check Properties that are required together | Make sure CloudFormation resource properties are included together when required | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `resources` | +| E2522 | Check Properties that need at least one of a list of properties | Making sure CloudFormation properties that require at least one property from a list. More than one can be included. | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `resources` | +| E2523 | Check Properties that need only one of a list of properties | Making sure CloudFormation properties that require only one property from a list. One has to be specified. | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `resources` | | E2530 | Check Lambda Memory Size Properties | See if Lambda Memory Size is valid | [Source](https://docs.aws.amazon.com/lambda/latest/dg/API_CreateFunction.html#SSS-CreateFunction-request-MemorySize) | `resources`,`lambda` | | E2532 | Check State Machine Definition for proper syntax | Check the State Machine String Definition to make sure its JSON. Validate basic syntax of the file to determine validity. | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-stepfunctions-statemachine.html) | `resources`,`stepfunctions` | | E2540 | CodePipeline Stages | See if CodePipeline stages are set correctly | [Source](https://docs.aws.amazon.com/codepipeline/latest/userguide/reference-pipeline-structure.html#pipeline-requirements) | `properties`,`codepipeline` | | E2541 | CodePipeline Stage Actions | See if CodePipeline stage actions are set correctly | [Source](https://docs.aws.amazon.com/codepipeline/latest/userguide/reference-pipeline-structure.html#pipeline-requirements) | `resources`,`codepipeline` | -| E3001 | Basic CloudFormation Resource Check | Making sure the basic CloudFormation resources are properly configured | [Source](https://github.com/awslabs/cfn-python-lint) | `resources` | -| E3002 | Resource properties are valid | Making sure that resources properties are properly configured | [Source](https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#properties) | `resources` | -| E3003 | Required Resource Parameters are missing | Making sure that Resources properties that are required exist | [Source](https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#required) | `resources` | -| E3004 | Resource dependencies are not circular | Check that Resources are not circularly dependent by Ref, Sub, or GetAtt | [Source](https://github.com/awslabs/cfn-python-lint) | `resources`,`circularly` | +| E3001 | Basic CloudFormation Resource Check | Making sure the basic CloudFormation resources are properly configured | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `resources` | +| E3002 | Resource properties are valid | Making sure that resources properties are properly configured | [Source](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#properties) | `resources` | +| E3003 | Required Resource Parameters are missing | Making sure that Resources properties that are required exist | [Source](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#required) | `resources` | +| E3004 | Resource dependencies are not circular | Check that Resources are not circularly dependent by Ref, Sub, or GetAtt | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `resources`,`circularly` | | E3005 | Check DependsOn values for Resources | Check that the DependsOn values are valid | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-dependson.html) | `resources`,`dependson` | | E3006 | Resources have appropriate names | Check if Resources are properly named (A-Za-z0-9) | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/resources-section-structure.html#resources-section-structure-logicalid) | `resources` | | E3008 | Check values of properties for valid Refs and GetAtts | Checks resource properties for Ref and GetAtt values | [Source]() | `resources` | | E3010 | Resource limit not exceeded | Check the number of Resources in the template is lessthan the upper limit | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cloudformation-limits.html) | `resources`,`limits` | | E3011 | Resource name limit not exceeded | Check the size of Resource names in the template is less than the upper limit | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cloudformation-limits.html) | `resources`,`limits` | -| E3012 | Check resource properties values | Checks resource property values with Primitive Types for values that match those types. | [Source](https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype) | `resources` | +| E3012 | Check resource properties values | Checks resource property values with Primitive Types for values that match those types. | [Source](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype) | `resources` | | E3013 | CloudFront Aliases | CloudFront aliases should contain valid domain names | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-distributionconfig.html#cfn-cloudfront-distribution-distributionconfig-aliases) | `properties`,`cloudfront` | | E3016 | Check the configuration of a resources UpdatePolicy | Make sure a resources UpdatePolicy is properly configured | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-updatepolicy.html) | `resources`,`updatepolicy` | | E3020 | Validate Route53 RecordSets | Check if all RecordSets are correctly configured | [Source](https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/ResourceRecordTypes.html) | `resources`,`route53`,`record_set` | @@ -99,7 +99,7 @@ The following **104** rules are applied by this linter: | E3022 | Resource SubnetRouteTableAssociation Properties | Validate there is only one SubnetRouteTableAssociation per subnet | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-subnet-route-table-assoc.html) | `resources`,`subnet`,`route table` | | E3024 | Validate that ProvisionedThroughput is not specified with BillingMode PAY_PER_REQUEST | When using ProvisionedThroughput with BillingMode PAY_PER_REQUEST will result in BillingMode being changed to PROVISIONED | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-dynamodb-table.html) | `resources`,`dynamodb`,`provisioned_throughput`,`billing_mode` | | E3025 | RDS instance type is compatible with the RDS type | Check the RDS instance types are supported by the type of RDS engine. Only if the values are strings will this be checked. | [Source](https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.DBInstanceClass.html) | `resources`,`rds` | -| E3030 | Check if properties have a valid value | Check if properties have a valid value in case of an enumator | [Source](https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#allowedvalue) | `resources`,`property`,`allowed value` | +| E3030 | Check if properties have a valid value | Check if properties have a valid value in case of an enumator | [Source](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#allowedvalue) | `resources`,`property`,`allowed value` | | E3035 | Check DeletionPolicy values for Resources | Check that the DeletionPolicy values are valid | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-deletionpolicy.html) | `resources`,`deletionpolicy` | | E3036 | Check UpdateReplacePolicy values for Resources | Check that the UpdateReplacePolicy values are valid | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-updatereplacepolicy.html) | `resources`,`updatereplacepolicy` | | E4001 | Metadata Interface have appropriate properties | Metadata Interface properties are properly configured | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudformation-interface.html) | `metadata` | @@ -124,8 +124,8 @@ The following **104** rules are applied by this linter: | W1011 | FindInMap keys exist in the map | Checks the keys in a FindInMap to make sure they exist. Check only if the Map Name is a string and if the key is a string. | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-findinmap.html) | `functions`,`findinmap` | | W1019 | Sub validation of parameters | Validate that Fn::Sub Parameters are used | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-sub.html) | `functions`,`sub` | | W1020 | Sub isn't needed if it doesn't have a variable defined | Checks sub strings to see if a variable is defined. | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-sub.html) | `functions`,`sub` | -| W2001 | Check if Parameters are Used | Making sure the parameters defined are used | [Source](https://github.com/awslabs/cfn-python-lint) | `parameters` | -| W2030 | Check if parameters have a valid value | Check if parameters have a valid value in case of an enumator. The Parameters allowed values is based on the usages in property (Ref) | [Source](https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#allowedvalue) | `resources`,`property`,`allowed value` | +| W2001 | Check if Parameters are Used | Making sure the parameters defined are used | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `parameters` | +| W2030 | Check if parameters have a valid value | Check if parameters have a valid value in case of an enumator. The Parameters allowed values is based on the usages in property (Ref) | [Source](https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#allowedvalue) | `resources`,`property`,`allowed value` | | W2501 | Check if Password Properties are correctly configured | Password properties should be strings and if parameter using NoEcho | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/best-practices.html#creds) | `parameters`,`passwords` | | W2506 | Check if ImageId Parameters have the correct type | See if there are any refs for ImageId to a parameter of inappropriate type. Appropriate Types are [AWS::EC2::Image::Id, AWS::SSM::Parameter::Value] | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/best-practices.html#parmtypes) | `parameters`,`imageid` | | W2507 | Security Group Parameters are of correct type AWS::EC2::SecurityGroup::Id | Check if a parameter is being used in a resource for Security Group. If it is make sure it is of type AWS::EC2::SecurityGroup::Id | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/best-practices.html#parmtypes) | `parameters`,`securitygroup` | @@ -135,8 +135,8 @@ The following **104** rules are applied by this linter: | W2511 | Check IAM Resource Policies syntax | See if the elements inside an IAM Resource policy are configured correctly. | [Source](https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements.html) | `properties`,`iam` | | W3002 | Warn when properties are configured to only work with the package command | Some properties can be configured to only work with the CloudFormationpackage command. Warn when this is the case so user is aware. | [Source](https://docs.aws.amazon.com/cli/latest/reference/cloudformation/package.html) | `resources` | | W3005 | Check obsolete DependsOn configuration for Resources | Check if DependsOn is specified if not needed. A Ref or a Fn::GetAtt already is an implicit dependency. | [Source](https://aws.amazon.com/blogs/devops/optimize-aws-cloudformation-templates/) | `resources`,`dependson` | -| W3010 | Availability Zone Parameters should not be hardcoded | Check if an Availability Zone property is hardcoded. | [Source](https://github.com/awslabs/cfn-python-lint) | `parameters`,`availabilityzone` | +| W3010 | Availability Zone Parameters should not be hardcoded | Check if an Availability Zone property is hardcoded. | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `parameters`,`availabilityzone` | | W4001 | Metadata Interface parameters exist | Metadata Interface parameters actually exist | [Source](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudformation-interface.html) | `metadata` | -| W6001 | Check Outputs using ImportValue | Check if the Output value is set using ImportValue, so creating an Output of an Output | [Source](https://github.com/awslabs/cfn-python-lint) | `outputs`,`importvalue` | -| W7001 | Check if Mappings are Used | Making sure the mappings defined are used | [Source](https://github.com/awslabs/cfn-python-lint) | `conditions` | -| W8001 | Check if Conditions are Used | Making sure the conditions defined are used | [Source](https://github.com/awslabs/cfn-python-lint) | `conditions` | +| W6001 | Check Outputs using ImportValue | Check if the Output value is set using ImportValue, so creating an Output of an Output | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `outputs`,`importvalue` | +| W7001 | Check if Mappings are Used | Making sure the mappings defined are used | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `conditions` | +| W8001 | Check if Conditions are Used | Making sure the conditions defined are used | [Source](https://github.com/aws-cloudformation/cfn-python-lint) | `conditions` | diff --git a/setup.py b/setup.py index 5c2c658317..d1566295e9 100644 --- a/setup.py +++ b/setup.py @@ -42,7 +42,7 @@ def get_version(filename): keywords='aws, lint', author='kddejong', author_email='kddejong@amazon.com', - url='https://github.com/awslabs/cfn-python-lint', + url='https://github.com/aws-cloudformation/cfn-python-lint', package_dir={'': 'src'}, package_data={'cfnlint': [ 'data/CloudSpecs/*.json', diff --git a/src/cfnlint/__init__.py b/src/cfnlint/__init__.py index 6102dc40ac..37cf4a25f3 100644 --- a/src/cfnlint/__init__.py +++ b/src/cfnlint/__init__.py @@ -1224,7 +1224,7 @@ class ParseError(cfnlint.CloudFormationLintRule): id = 'E0000' shortdesc = 'Parsing error found when parsing the template' description = 'Checks for Null values and Duplicate values in resources' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['base'] class TransformError(cfnlint.CloudFormationLintRule): @@ -1232,7 +1232,7 @@ class TransformError(cfnlint.CloudFormationLintRule): id = 'E0001' shortdesc = 'Error found when transforming the template' description = 'Errors found when performing transformation on the template' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['base', 'transform'] class RuleError(cfnlint.CloudFormationLintRule): @@ -1240,5 +1240,5 @@ class RuleError(cfnlint.CloudFormationLintRule): id = 'E0002' shortdesc = 'Error processing rule on the template' description = 'Errors found when processing a rule on the template' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['base', 'rule'] diff --git a/src/cfnlint/data/CfnLintCli/config/schema.json b/src/cfnlint/data/CfnLintCli/config/schema.json index bcbf1261e5..74c56b317e 100644 --- a/src/cfnlint/data/CfnLintCli/config/schema.json +++ b/src/cfnlint/data/CfnLintCli/config/schema.json @@ -1,5 +1,5 @@ { - "$id": "https://github.com/awslabs/cfn-python-lint/blob/master/src/cfnlint/data/CfnLintCli/config/schema.json", + "$id": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/src/cfnlint/data/CfnLintCli/config/schema.json", "$schema": "http://json-schema.org/draft-07/schema#", "description": "CFNLINTRC configuration schema", "title": "CFNLINTRC JSON Schema", diff --git a/src/cfnlint/rules/conditions/Used.py b/src/cfnlint/rules/conditions/Used.py index dfccd7dbb0..b9b62407c1 100644 --- a/src/cfnlint/rules/conditions/Used.py +++ b/src/cfnlint/rules/conditions/Used.py @@ -24,7 +24,7 @@ class Used(CloudFormationLintRule): id = 'W8001' shortdesc = 'Check if Conditions are Used' description = 'Making sure the conditions defined are used' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['conditions'] def match(self, cfn): diff --git a/src/cfnlint/rules/mappings/Used.py b/src/cfnlint/rules/mappings/Used.py index e631dcdd0e..52ae7c8bf0 100644 --- a/src/cfnlint/rules/mappings/Used.py +++ b/src/cfnlint/rules/mappings/Used.py @@ -23,7 +23,7 @@ class Used(CloudFormationLintRule): id = 'W7001' shortdesc = 'Check if Mappings are Used' description = 'Making sure the mappings defined are used' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['conditions'] def match(self, cfn): diff --git a/src/cfnlint/rules/outputs/ImportValue.py b/src/cfnlint/rules/outputs/ImportValue.py index 063006ef5a..d3945f98a4 100644 --- a/src/cfnlint/rules/outputs/ImportValue.py +++ b/src/cfnlint/rules/outputs/ImportValue.py @@ -23,7 +23,7 @@ class ImportValue(CloudFormationLintRule): id = 'W6001' shortdesc = 'Check Outputs using ImportValue' description = 'Check if the Output value is set using ImportValue, so creating an Output of an Output' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['outputs', 'importvalue'] def match(self, cfn): diff --git a/src/cfnlint/rules/parameters/AllowedValue.py b/src/cfnlint/rules/parameters/AllowedValue.py index 98aeb37869..fb5b2c157f 100644 --- a/src/cfnlint/rules/parameters/AllowedValue.py +++ b/src/cfnlint/rules/parameters/AllowedValue.py @@ -25,7 +25,7 @@ class AllowedValue(CloudFormationLintRule): id = 'W2030' shortdesc = 'Check if parameters have a valid value' description = 'Check if parameters have a valid value in case of an enumator. The Parameter''s allowed values is based on the usages in property (Ref)' - source_url = 'https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#allowedvalue' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#allowedvalue' tags = ['resources', 'property', 'allowed value'] def initialize(self, cfn): diff --git a/src/cfnlint/rules/parameters/Used.py b/src/cfnlint/rules/parameters/Used.py index 54cbbf6de1..194d9b6c3b 100644 --- a/src/cfnlint/rules/parameters/Used.py +++ b/src/cfnlint/rules/parameters/Used.py @@ -26,7 +26,7 @@ class Used(CloudFormationLintRule): id = 'W2001' shortdesc = 'Check if Parameters are Used' description = 'Making sure the parameters defined are used' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['parameters'] def searchstring(self, string, parameter): diff --git a/src/cfnlint/rules/resources/CircularDependency.py b/src/cfnlint/rules/resources/CircularDependency.py index 53b71aab32..8a4afe6450 100644 --- a/src/cfnlint/rules/resources/CircularDependency.py +++ b/src/cfnlint/rules/resources/CircularDependency.py @@ -26,7 +26,7 @@ class CircularDependency(CloudFormationLintRule): shortdesc = 'Resource dependencies are not circular' description = 'Check that Resources are not circularly dependent ' \ 'by Ref, Sub, or GetAtt' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['resources', 'circularly'] def searchstring(self, string): diff --git a/src/cfnlint/rules/resources/Configuration.py b/src/cfnlint/rules/resources/Configuration.py index dbee862b78..5fdf9a2cd4 100644 --- a/src/cfnlint/rules/resources/Configuration.py +++ b/src/cfnlint/rules/resources/Configuration.py @@ -25,7 +25,7 @@ class Configuration(CloudFormationLintRule): shortdesc = 'Basic CloudFormation Resource Check' description = 'Making sure the basic CloudFormation resources ' + \ 'are properly configured' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['resources'] def match(self, cfn): diff --git a/src/cfnlint/rules/resources/properties/AllowedValue.py b/src/cfnlint/rules/resources/properties/AllowedValue.py index e6932403c2..a52f9df30e 100644 --- a/src/cfnlint/rules/resources/properties/AllowedValue.py +++ b/src/cfnlint/rules/resources/properties/AllowedValue.py @@ -25,7 +25,7 @@ class AllowedValue(CloudFormationLintRule): id = 'E3030' shortdesc = 'Check if properties have a valid value' description = 'Check if properties have a valid value in case of an enumator' - source_url = 'https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#allowedvalue' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#allowedvalue' tags = ['resources', 'property', 'allowed value'] def initialize(self, cfn): diff --git a/src/cfnlint/rules/resources/properties/AtLeastOne.py b/src/cfnlint/rules/resources/properties/AtLeastOne.py index 394d4c5286..5baf4ba7ad 100644 --- a/src/cfnlint/rules/resources/properties/AtLeastOne.py +++ b/src/cfnlint/rules/resources/properties/AtLeastOne.py @@ -26,7 +26,7 @@ class AtLeastOne(CloudFormationLintRule): description = 'Making sure CloudFormation properties ' + \ 'that require at least one property from a list. ' + \ 'More than one can be included.' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['resources'] def __init__(self): diff --git a/src/cfnlint/rules/resources/properties/AvailabilityZone.py b/src/cfnlint/rules/resources/properties/AvailabilityZone.py index 77b12fa67f..891e145be5 100644 --- a/src/cfnlint/rules/resources/properties/AvailabilityZone.py +++ b/src/cfnlint/rules/resources/properties/AvailabilityZone.py @@ -23,7 +23,7 @@ class AvailabilityZone(CloudFormationLintRule): id = 'W3010' shortdesc = 'Availability Zone Parameters should not be hardcoded' description = 'Check if an Availability Zone property is hardcoded.' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['parameters', 'availabilityzone'] def __init__(self): diff --git a/src/cfnlint/rules/resources/properties/Exclusive.py b/src/cfnlint/rules/resources/properties/Exclusive.py index 3d719c9fa9..c18c69a51a 100644 --- a/src/cfnlint/rules/resources/properties/Exclusive.py +++ b/src/cfnlint/rules/resources/properties/Exclusive.py @@ -25,7 +25,7 @@ class Exclusive(CloudFormationLintRule): shortdesc = 'Check Properties that are mutually exclusive' description = 'Making sure CloudFormation properties ' + \ 'that are exclusive are not defined' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['resources'] def __init__(self): diff --git a/src/cfnlint/rules/resources/properties/Inclusive.py b/src/cfnlint/rules/resources/properties/Inclusive.py index d6d1389157..8730ccf123 100644 --- a/src/cfnlint/rules/resources/properties/Inclusive.py +++ b/src/cfnlint/rules/resources/properties/Inclusive.py @@ -25,7 +25,7 @@ class Inclusive(CloudFormationLintRule): shortdesc = 'Check Properties that are required together' description = 'Make sure CloudFormation resource properties ' + \ 'are included together when required' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['resources'] def __init__(self): diff --git a/src/cfnlint/rules/resources/properties/OnlyOne.py b/src/cfnlint/rules/resources/properties/OnlyOne.py index dff5dfd0e8..2ce0aedf43 100644 --- a/src/cfnlint/rules/resources/properties/OnlyOne.py +++ b/src/cfnlint/rules/resources/properties/OnlyOne.py @@ -26,7 +26,7 @@ class OnlyOne(CloudFormationLintRule): description = 'Making sure CloudFormation properties ' + \ 'that require only one property from a list. ' + \ 'One has to be specified.' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['resources'] def __init__(self): diff --git a/src/cfnlint/rules/resources/properties/Properties.py b/src/cfnlint/rules/resources/properties/Properties.py index a48937eaf5..16508a5adf 100644 --- a/src/cfnlint/rules/resources/properties/Properties.py +++ b/src/cfnlint/rules/resources/properties/Properties.py @@ -26,7 +26,7 @@ class Properties(CloudFormationLintRule): shortdesc = 'Resource properties are valid' description = 'Making sure that resources properties ' + \ 'are properly configured' - source_url = 'https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#properties' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#properties' tags = ['resources'] def __init__(self): diff --git a/src/cfnlint/rules/resources/properties/Required.py b/src/cfnlint/rules/resources/properties/Required.py index 2634896683..23b6b3db15 100644 --- a/src/cfnlint/rules/resources/properties/Required.py +++ b/src/cfnlint/rules/resources/properties/Required.py @@ -25,7 +25,7 @@ class Required(CloudFormationLintRule): shortdesc = 'Required Resource Parameters are missing' description = 'Making sure that Resources properties ' + \ 'that are required exist' - source_url = 'https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#required' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#required' tags = ['resources'] cfn = {} diff --git a/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py b/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py index 17969b698e..98ca1fcb2f 100644 --- a/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py +++ b/src/cfnlint/rules/resources/properties/ValuePrimitiveType.py @@ -27,7 +27,7 @@ class ValuePrimitiveType(CloudFormationLintRule): shortdesc = 'Check resource properties values' description = 'Checks resource property values with Primitive Types for ' \ 'values that match those types.' - source_url = 'https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype' tags = ['resources'] def __init__(self): diff --git a/src/cfnlint/rules/templates/Base.py b/src/cfnlint/rules/templates/Base.py index b9dbc539ef..3a7f834ffb 100644 --- a/src/cfnlint/rules/templates/Base.py +++ b/src/cfnlint/rules/templates/Base.py @@ -23,7 +23,7 @@ class Base(CloudFormationLintRule): id = 'E1001' shortdesc = 'Basic CloudFormation Template Configuration' description = 'Making sure the basic CloudFormation template components are properly configured' - source_url = 'https://github.com/awslabs/cfn-python-lint' + source_url = 'https://github.com/aws-cloudformation/cfn-python-lint' tags = ['base'] required_keys = [ diff --git a/test/fixtures/results/quickstart/nist_application.json b/test/fixtures/results/quickstart/nist_application.json index 67381cd489..a6ec0ce33a 100644 --- a/test/fixtures/results/quickstart/nist_application.json +++ b/test/fixtures/results/quickstart/nist_application.json @@ -130,7 +130,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -151,7 +151,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -172,7 +172,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -214,7 +214,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -235,7 +235,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -256,7 +256,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -298,7 +298,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -319,7 +319,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -340,7 +340,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -361,7 +361,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -382,7 +382,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -403,7 +403,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -424,7 +424,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -445,7 +445,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -466,7 +466,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -487,7 +487,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -508,7 +508,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -529,7 +529,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -550,7 +550,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -571,7 +571,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -613,7 +613,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -634,7 +634,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -655,7 +655,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -718,7 +718,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -739,7 +739,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -802,7 +802,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -823,7 +823,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -886,7 +886,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -907,7 +907,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -949,7 +949,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -970,7 +970,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -991,7 +991,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1012,7 +1012,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1033,7 +1033,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1054,7 +1054,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1075,7 +1075,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1096,7 +1096,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1117,7 +1117,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1138,7 +1138,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1159,7 +1159,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1180,7 +1180,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1201,7 +1201,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1222,7 +1222,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1243,7 +1243,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1264,7 +1264,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1285,7 +1285,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1306,7 +1306,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1327,7 +1327,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1348,7 +1348,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1369,7 +1369,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1390,7 +1390,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1411,7 +1411,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -1432,7 +1432,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { diff --git a/test/fixtures/results/quickstart/nist_config_rules.json b/test/fixtures/results/quickstart/nist_config_rules.json index 199ed2d10a..38b0345a56 100644 --- a/test/fixtures/results/quickstart/nist_config_rules.json +++ b/test/fixtures/results/quickstart/nist_config_rules.json @@ -25,7 +25,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint" }, "Location": { "Start": { @@ -67,7 +67,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint" }, "Location": { "Start": { diff --git a/test/fixtures/results/quickstart/nist_high_master.json b/test/fixtures/results/quickstart/nist_high_master.json index 0fe1c8094f..1ae7b00385 100644 --- a/test/fixtures/results/quickstart/nist_high_master.json +++ b/test/fixtures/results/quickstart/nist_high_master.json @@ -17,7 +17,7 @@ "Description": "Making sure the conditions defined are used", "Id": "W8001", "ShortDescription": "Check if Conditions are Used", - "Source": "https://github.com/awslabs/cfn-python-lint" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint" } }, { @@ -395,7 +395,7 @@ "Description": "Checks resource property values with Primitive Types for values that match those types.", "Id": "E3012", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" } }, { @@ -416,7 +416,7 @@ "Description": "Checks resource property values with Primitive Types for values that match those types.", "Id": "E3012", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" } }, { @@ -437,7 +437,7 @@ "Description": "Checks resource property values with Primitive Types for values that match those types.", "Id": "E3012", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" } }, { @@ -458,7 +458,7 @@ "Description": "Checks resource property values with Primitive Types for values that match those types.", "Id": "E3012", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" } }, { @@ -605,7 +605,7 @@ "Description": "Checks resource property values with Primitive Types for values that match those types.", "Id": "E3012", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" } }, { @@ -626,7 +626,7 @@ "Description": "Checks resource property values with Primitive Types for values that match those types.", "Id": "E3012", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" } } ] diff --git a/test/fixtures/results/quickstart/openshift.json b/test/fixtures/results/quickstart/openshift.json index 6bcb893868..52b65f8b6f 100644 --- a/test/fixtures/results/quickstart/openshift.json +++ b/test/fixtures/results/quickstart/openshift.json @@ -4,7 +4,7 @@ "Id": "W7001", "Description": "Making sure the mappings defined are used", "ShortDescription": "Check if Mappings are Used", - "Source": "https://github.com/awslabs/cfn-python-lint" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint" }, "Location": { "Start": { @@ -67,7 +67,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -88,7 +88,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -151,7 +151,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -172,7 +172,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -193,7 +193,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -214,7 +214,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -235,7 +235,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -277,7 +277,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -298,7 +298,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -319,7 +319,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -340,7 +340,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -361,7 +361,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -382,7 +382,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -403,7 +403,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -424,7 +424,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -445,7 +445,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -466,7 +466,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -487,7 +487,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -508,7 +508,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -529,7 +529,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { @@ -550,7 +550,7 @@ "Id": "E3012", "Description": "Checks resource property values with Primitive Types for values that match those types.", "ShortDescription": "Check resource properties values", - "Source": "https://github.com/awslabs/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" + "Source": "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/docs/cfn-resource-specification.md#valueprimitivetype" }, "Location": { "Start": { diff --git a/test/fixtures/templates/bad/resources_codepipeline_action_artifact_counts.yaml b/test/fixtures/templates/bad/resources_codepipeline_action_artifact_counts.yaml index cc8fdb3800..44a331f625 100644 --- a/test/fixtures/templates/bad/resources_codepipeline_action_artifact_counts.yaml +++ b/test/fixtures/templates/bad/resources_codepipeline_action_artifact_counts.yaml @@ -20,7 +20,7 @@ Resources: OutputArtifacts: - Name: MyApp Configuration: - Owner: awslabs + Owner: aws-cloudformation Repo: cfn-python-lint PollForSourceChanges: true Branch: master diff --git a/test/fixtures/templates/bad/resources_codepipeline_action_invalid_version.yaml b/test/fixtures/templates/bad/resources_codepipeline_action_invalid_version.yaml index 63157f84f0..0470f37b24 100644 --- a/test/fixtures/templates/bad/resources_codepipeline_action_invalid_version.yaml +++ b/test/fixtures/templates/bad/resources_codepipeline_action_invalid_version.yaml @@ -20,7 +20,7 @@ Resources: OutputArtifacts: - Name: MyApp Configuration: - Owner: awslabs + Owner: aws-cloudformation Repo: cfn-python-lint PollForSourceChanges: true Branch: master diff --git a/test/fixtures/templates/bad/resources_codepipeline_action_non_unique.yaml b/test/fixtures/templates/bad/resources_codepipeline_action_non_unique.yaml index 089407eb37..ae8c0c2a38 100644 --- a/test/fixtures/templates/bad/resources_codepipeline_action_non_unique.yaml +++ b/test/fixtures/templates/bad/resources_codepipeline_action_non_unique.yaml @@ -20,7 +20,7 @@ Resources: OutputArtifacts: - Name: MyApp Configuration: - Owner: awslabs + Owner: aws-cloudformation Repo: cfn-python-lint PollForSourceChanges: true Branch: master diff --git a/test/fixtures/templates/bad/resources_codepipeline_stages_non_unique.yaml b/test/fixtures/templates/bad/resources_codepipeline_stages_non_unique.yaml index b8ee38a522..e5dfbd54fc 100644 --- a/test/fixtures/templates/bad/resources_codepipeline_stages_non_unique.yaml +++ b/test/fixtures/templates/bad/resources_codepipeline_stages_non_unique.yaml @@ -22,7 +22,7 @@ Resources: OutputArtifacts: - Name: MyApp Configuration: - Owner: awslabs + Owner: aws-cloudformation Repo: cfn-python-lint PollForSourceChanges: true Branch: master diff --git a/test/fixtures/templates/bad/resources_codepipeline_stages_one_stage.yaml b/test/fixtures/templates/bad/resources_codepipeline_stages_one_stage.yaml index d168171c9c..a6e2f018a4 100644 --- a/test/fixtures/templates/bad/resources_codepipeline_stages_one_stage.yaml +++ b/test/fixtures/templates/bad/resources_codepipeline_stages_one_stage.yaml @@ -22,7 +22,7 @@ Resources: OutputArtifacts: - "MyApp" Configuration: - Owner: awslabs + Owner: aws-cloudformation Repo: cfn-python-lint PollForSourceChanges: true Branch: master diff --git a/test/fixtures/templates/bad/resources_codepipeline_stages_second_stage.yaml b/test/fixtures/templates/bad/resources_codepipeline_stages_second_stage.yaml index 6e7180d272..37ce23eb79 100644 --- a/test/fixtures/templates/bad/resources_codepipeline_stages_second_stage.yaml +++ b/test/fixtures/templates/bad/resources_codepipeline_stages_second_stage.yaml @@ -22,7 +22,7 @@ Resources: OutputArtifacts: - Name: MyApp Configuration: - Owner: awslabs + Owner: aws-cloudformation Repo: cfn-python-lint PollForSourceChanges: true Branch: master @@ -38,7 +38,7 @@ Resources: OutputArtifacts: - Name: MyApp2 Configuration: - Owner: awslabs + Owner: aws-cloudformation Repo: cfn-python-lint PollForSourceChanges: true Branch: master diff --git a/test/fixtures/templates/good/resources_codepipeline.yaml b/test/fixtures/templates/good/resources_codepipeline.yaml index 3aac313ae9..eed0f322fe 100644 --- a/test/fixtures/templates/good/resources_codepipeline.yaml +++ b/test/fixtures/templates/good/resources_codepipeline.yaml @@ -22,7 +22,7 @@ Resources: OutputArtifacts: - Name: MyApp Configuration: - Owner: awslabs + Owner: aws-cloudformation Repo: cfn-python-lint PollForSourceChanges: true Branch: master