Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID Registry Docs #389

Open
stas opened this issue Jan 28, 2025 · 2 comments
Open

ID Registry Docs #389

stas opened this issue Jan 28, 2025 · 2 comments

Comments

@stas
Copy link

stas commented Jan 28, 2025

Hi there,
I'm trying to follow the ID Registry steps/examples and none of these seem to work.

Overall the state of the docs could use some love. There's typos and just broken examples.

Take this page:
https://docs.farcaster.xyz/developers/guides/accounts/change-custody

  • I'm confused why there are two examples, one for the @farcaster/hub-web and one for viem, but in the later we still have a dependency to the @farcaster/hub-web package?!?
  • How do we run these examples, these are .ts files, but copy-pasting the contents will give an error

    ERROR: Top-level await is currently not supported with the "cjs" output format

  • there's an ...IdContract, contract without any reference
  • signature needs to be in fact toHex(signature) ?!
  • I couldn't get a signature to work, keep getting 'Error: InvalidSignature()`, I think it needs some clear explanation which account (recipient or sender) is creating the signature and who's signing the transaction

Sorry for the wall of text, but I've spend a couple of hours trying to figure things out and I'm still blocked.

Would like to mention that the change of custody functionality is a security matter. I think these docs, but ideally tools to handle this, should be a top priority to be clearly available.

Appreciate any help with these

@stas
Copy link
Author

stas commented Jan 28, 2025

@stas
Copy link
Author

stas commented Jan 28, 2025

Implementation available in farcasterxyz/hub-monorepo#2506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant