[Feature] Don't install cfgs module as a top level Python import

[samuela]

Feature

In the process of packaging nocturne for Nixpkgs (NixOS/nixpkgs#208847 (comment)), it was discovered that nocturne doesn't just install "nocturne" as a top-level package -- eg import nocturne -- but also "cfgs". In fact, having cfgs available on the top-level is required in order to import nocturne:

nocturne/nocturne/__init__.py

Line 27 in ae0a4e3

from cfgs.config import PROCESSED_TRAIN_NO_TL, PROCESSED_VALID_NO_TL, PROJECT_PATH

Is this intentional? Polluting the top-level scope with "cfgs" seems undesirable. Would it be possible to move cfgs out of the top-level package namespace?

[eugenevinitsky]

Thanks for flagging this! @xiaomengy @nathanlct do you see any reason this needs to be a top level folder? I don't.

[nathanlct]

That folder seems to be mostly Hydra configs associated with the examples/ folder (and the paths are still eugenevinitsky/), that's probably why it's a top folder. But why are those paths PROCESSED_TRAIN_NO_TL hardcoded in and imported from config.py, and not loaded from config.yml?

[eugenevinitsky]

@samuela we'll submit a PR moving this out, do you have a timeline you need this on?

[samuela]

Thanks @eugenevinitsky! No rush on my end!