Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to MAPPO code to make it functional #39

Merged
merged 1 commit into from
Jul 20, 2022
Merged

changes to MAPPO code to make it functional #39

merged 1 commit into from
Jul 20, 2022

Conversation

eugenevinitsky
Copy link
Collaborator

@eugenevinitsky eugenevinitsky commented Jul 19, 2022 •
edited
Loading

Fix #38

  1. cfg.algo->cfg.algorithm
  2. simplify wrapper

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 19, 2022
@eugenevinitsky
Copy link
Collaborator Author

@xiaomengy or @nathanlct can you take a look?

@eugenevinitsky eugenevinitsky mentioned this pull request Jul 19, 2022
Open
xiaomengy
xiaomengy approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@xiaomengy xiaomengy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, please make sure it will not hurt the experiments.

@eugenevinitsky
Copy link
Collaborator Author

Hey @xiaomengy we've never actually run experiments with the MAPPO code, only with SampleFactory. The README hopefully makes clear that these libraries are untested and are just provided as convenience for users

@eugenevinitsky
changes to MAPPO code:
416a026 
1) cfg.algo->cfg.algorithm
2) simplify wrapper
@eugenevinitsky eugenevinitsky merged commit 4d60987 into main Jul 20, 2022
@eugenevinitsky eugenevinitsky deleted the fix_mappo branch July 20, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaomengy xiaomengy xiaomengy approved these changes

@nathanlct nathanlct Awaiting requested review from nathanlct

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues Running MAPPO
3 participants
@eugenevinitsky @xiaomengy @facebook-github-bot