From f9677e6be94e963b6b9ba7ca1906f58af9169b55 Mon Sep 17 00:00:00 2001 From: Clara Rull Date: Fri, 31 Jan 2025 08:10:38 -0800 Subject: [PATCH] Improve logging when ratelimit is exceeded Summary: What the title says This will help with filtering on scuba as ratelimis will follow the same format wether tracked/enforced or dfferent metrics Reviewed By: lmvasquezg Differential Revision: D68896071 fbshipit-source-id: ee1687a05c8322d846045ae8ce9ffc66203e3bb6 --- eden/mononoke/edenapi_service/src/utils/rate_limit.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eden/mononoke/edenapi_service/src/utils/rate_limit.rs b/eden/mononoke/edenapi_service/src/utils/rate_limit.rs index efb53e3337c48..e985d04f736c1 100644 --- a/eden/mononoke/edenapi_service/src/utils/rate_limit.rs +++ b/eden/mononoke/edenapi_service/src/utils/rate_limit.rs @@ -81,7 +81,7 @@ pub async fn counter_check_and_bump<'a>( count, max_value, ); - let msg = format!("{}: Exceeded (log only)", rate_limit_name); + let msg = format!("Rate limit exceeded: {} (log only)", rate_limit_name); scuba.log_with_msg(&msg, None); Ok(()) } else { @@ -92,7 +92,7 @@ pub async fn counter_check_and_bump<'a>( count, max_value, ); - let msg = format!("{}: Blocked", rate_limit_name); + let msg = format!("Rate limit exceeded: {} (enforced)", rate_limit_name); scuba.log_with_msg(&msg, None); Err(anyhow!(msg)) }