Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor differences when solving TIMES-NZ cases #316

Open
olejandro opened this issue Feb 5, 2025 · 8 comments
Open

Minor differences when solving TIMES-NZ cases #316

olejandro opened this issue Feb 5, 2025 · 8 comments

Comments

@olejandro
Copy link
Member

There is a small difference in the objective function value when solving TIMES-NZ Kea using the outputs from the tool compared to the benchmark. I believe I've managed to narrow down the cause to the issues discussed here: https://forum.kanors-emr.org/showthread.php?tid=1254&page=1. More specifically, as mentioned by @Antti-L, when the PCG is a genuine group, the process will no longer contribute to the peak by capacity.

@olejandro
Copy link
Member Author

@Antti-L, are there any other differences between PCG being a commodity vs an actual group with a single member?

@Antti-L
Copy link

Antti-L commented Feb 5, 2025

In terms of functionality, I don't think so, there is nothing else that I can recall. It might additionally just cause a bit confusion to some users that access the model data and results from the full GDX files.

@olejandro
Copy link
Member Author

Ok, super, thanks!

@Antti-L
Copy link

Antti-L commented Feb 5, 2025

There is a small difference in the objective function value when solving TIMES-NZ Kea using the outputs from the tool compared to the benchmark.

Hmm..., but I see GDX diff reporting 3877 differences for Kea (under v0.2.1), unless I am misinterpreting it. I would be surprised if all those differences are about this PCG issue. So, I am curious whether you consider all those differences otherwise cosmetic?

@olejandro
Copy link
Member Author

Surprising, right? The PCG issue alone is responsible for 1000+. Another big one is BOTIME which we currently don't adjust. I am planning to open a PR in the benchmark repository with manual adjustments, so we can reach 100% and lock in the progress. I hope you'd be up for giving your opinion on the adjustments.

@olejandro olejandro changed the title Minor difference when solving TIMES-NZ Kea Minor differences when solving TIMES-NZ cases Feb 6, 2025
@olejandro
Copy link
Member Author

Just verified that the objective function for the other NZ case is reproduced, as well, once the PCG issue is corrected and HYD_DAM_BAN constraint is disabled. Regarding the latter, Veda drops it because UC_Sets on the sheet are disabled. @Antti-L, you mentioned in #291 that TIMES has defaults for it. I guess, it is okay for the tool not to drop the constraint then?

@Antti-L
Copy link

Antti-L commented Feb 6, 2025

HYD_DAM_BAN constraint is disabled

I assume you refer now to the TUI scenario, and not KEA? Sure, if the tool defines the UC_RHSRTS(r,'0') and UC_CAP for all regions even when no UC_Sets: R_E: is defined, then it would be okay. TIMES would set UC_R_EACH by default for all regions having UC_RHSR* defined, and the constraint would thus be correctly defined.

@olejandro
Copy link
Member Author

I assume you refer now to the TUI scenario, and not KEA?

Yes, here is what it looks like.

Image

No, regions are specified for UC_CAP, so currently it is filled in with all internal regions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants