Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codebase: For non upgradeable contracts consider using upgradeable contract as parents #454

Open
rapidddenis opened this issue Jun 26, 2024 · 1 comment
Open

Codebase: For non upgradeable contracts consider using upgradeable contract as parents #454

rapidddenis opened this issue Jun 26, 2024 · 1 comment

Comments

@rapidddenis
Copy link
Collaborator

E.g. AccessAdmin is non upgradeable contract which uses AccessManagedUpgradeable as parent.
Consider using AccessManaged + Initializable in such cases
@doerfli doerfli added this to the GIF v3 Audit Ready milestone Jun 27, 2024
@doerfli
Copy link
Contributor

doerfli commented Jul 19, 2024

please provide the list of impacted contracts

@doerfli doerfli removed this from the GIF v3 Audit Ready milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doerfli @rapidddenis