Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in pretty printing breaks dapptools integration tests #243

Open
asymmetric opened this issue Mar 28, 2023 · 4 comments
Open

Change in pretty printing breaks dapptools integration tests #243

asymmetric opened this issue Mar 28, 2023 · 4 comments

Comments

@asymmetric
Copy link
Contributor

Specifically, this test breaks like so.

From OOB discussions with @xwvvvvwx, I think this has something to do with how hevm changed its pretty printing of contract names in some logs.

@msooseth
Copy link
Collaborator

msooseth commented Sep 7, 2023

Hi @asymmetric is this still an issue? Can you please give an example if so? I'd like to make sure we can fix it, but without an example it's a bit hard :S Thank you in advance!

@msooseth
Copy link
Collaborator

Friendly ping @asymmetric :)

@asymmetric
Copy link
Contributor Author

@msooseth I think the consensus is that hevm will not be addressing issues relating to dapptools, as the latter is in the process of getting deprecated/archived.

Correct @d-xo ?

If so, this can be closed.

@d-xo
Copy link
Collaborator

d-xo commented Sep 22, 2023

I think that we're not aiming for backwards compat with dapptools anymore, but this is still a valid issue.

The issue here is that we're sometimes failing to pretty print contract names in the traces. I think we can keep it open as a low prio bug for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants