Skip to content
This repository has been archived by the owner on Oct 7, 2023. It is now read-only.

netlify: document ownership #11

Open
philips opened this issue May 28, 2019 · 10 comments
Open

netlify: document ownership #11

philips opened this issue May 28, 2019 · 10 comments

Comments

@philips
Copy link

philips commented May 28, 2019

Currently @philips, @caniszczyk and @lucperkins all have access to netlify used on etcd.io. We should document this here and give access to any other maintainers who need it.

@philips
Copy link
Author

philips commented Jan 30, 2020

@jberkus @lucperkins can you please document netlify ownership for etcd.io? There were caching issues getting the blog post out and I didn't really know who to bug.

@lucperkins
Copy link

@philips For future reference, that wasn’t a caching issue. The issue was that there was a specific time of day specified in the post’s front matter, which caused Hugo to consider the post as “future” and thus not create it. This can be avoided by specifying only month, day, and year.

@philips
Copy link
Author

philips commented Jan 30, 2020

@lucperkins yea, I guessed that was the reason after I sent the email.

Is there any public way to see build issues?

@lucperkins
Copy link

lucperkins commented Jan 30, 2020

@philips If the build fails, you see a big red X in the PR and are provided with a link to the build output. If it succeeds, you get a green check mark and a link to the deploy preview.

@philips
Copy link
Author

philips commented Jan 31, 2020 via email

@lucperkins
Copy link

lucperkins commented Jan 31, 2020

@philips These are the log for all deploys: https://app.netlify.com/sites/etcd/deploys

There’s also output for each PR.

@philips
Copy link
Author

philips commented Jan 31, 2020 via email

@lucperkins
Copy link

lucperkins commented Jan 31, 2020

@philips I'm looking around and I don't think there's a way to make the entire log viewable. Only the PR-specific log is public.

In terms of concerns about something breaking in master after a PR is merged, the website works just like "normal" CI-driven things. If there's a build failure, this is made clear in the PR and you cannot merge.

@philips
Copy link
Author

philips commented Jan 31, 2020 via email

@lucperkins
Copy link

lucperkins commented Jan 31, 2020

@philips If things aren't deploying, whoever created the PR will be able to see why in the CI error output. If people can't interpret that error output, they would indeed need to @ one of the site maintainers. But that's how all CI workflows work; it's not fundamentally different from, say, how the etcd code works.

You appear to object to this system. Could you possibly clarify your objection?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants