Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan to release etcd v3.5.18 #19119

Open
ivanvc opened this issue Dec 31, 2024 · 10 comments
Open

Plan to release etcd v3.5.18 #19119

ivanvc opened this issue Dec 31, 2024 · 10 comments
Labels
area/security priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature

Comments

@ivanvc
Copy link
Member

ivanvc commented Dec 31, 2024

What would you like to be added?

The etcd patch release criteria has been met for our release-3.5 stable release branch so we should release v3.5.18.

The list of commits included since the previous release is: v3.5.17...release-3.5:

Work in progress CHANGELOG is: https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md#v3518-tbc

List of pull requests we still need to backport from main to release-3.5 before the patch release is issued:

Release team

GitHub handle Role
@jmhbnz Release Lead
@ivanvc Release Advisor
@ghouscht Release Shadow

Why is this needed?

Regular patch releases are vital to ensure our users have bug-free and secure software.

@ivanvc
Copy link
Member Author

ivanvc commented Dec 31, 2024

I'd like to be a release advisor/shadow, as I'd like to see someone else running the release script after the first improvements from #18604. However, I can also be the lead if there are no volunteers.

@ghouscht
Copy link
Contributor

I haven't had much time in the last few weeks to help with etcd development but I think I could once again be a shadow for the release. I think I'm not yet familiar enough with the process to be a lead.

@taraspos
Copy link

taraspos commented Jan 6, 2025

@ivanvc would it be possible to include patches to x/crypto and x/net to resolve following vulnerabilities?

@cwayne18
Copy link

cwayne18 commented Jan 6, 2025

@taraspos looks like x/net was bumped here: bf3bb6d

@taraspos
Copy link

taraspos commented Jan 6, 2025

Yeah, but it needs to be backported into the release-3.5 branch to get into the 3.5.x release as far as I understand:

@cwayne18
Copy link

cwayne18 commented Jan 6, 2025

oof, of course you're correct, sorry, still seems i have holiday-brain. It would certainly be good to have those fixes included for us

@ivanvc
Copy link
Member Author

ivanvc commented Jan 6, 2025

@ivanvc would it be possible to include patches to x/crypto and x/net to resolve following vulnerabilities?

* [GHSA-v778-237x-gjrc](https://github.com/advisories/GHSA-v778-237x-gjrc)

* [GHSA-w32m-9786-jp63](https://github.com/advisories/GHSA-w32m-9786-jp63)

This makes sense. We're not directly affected by the vulnerability (https://github.com/etcd-io/etcd/actions/runs/12551556226/job/34996167337), but it's still a dependency with a CVE, and according to our Dependency Management documentation.

@ivanvc
Copy link
Member Author

ivanvc commented Jan 6, 2025

@jmhbnz, would you be interested in being part of the release team?

@jmhbnz jmhbnz added area/security priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 6, 2025
@jmhbnz
Copy link
Member

jmhbnz commented Jan 6, 2025

@jmhbnz, would you be interested in being part of the release team?

Thanks for the reminder on this, yes we need to get this release cut, we could aim to do it later this week perhaps.

I'll take lead for this one. Are you available to be a second pair of eyes for me as release advisor @ivanvc?

@ivanvc
Copy link
Member Author

ivanvc commented Jan 6, 2025

I'll take lead for this one. Are you available to be a second pair of eyes for me as release advisor @ivanvc?

Absolutely. Looks like we have a team. I'll groom to see if there are other potential PRs to backport. We also need to merge #19113 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature
Development

No branches or pull requests

5 participants