Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Require field must be in quotes (PACMAN-791) #49

Closed
wants to merge 1 commit into from

Conversation

tore-espressif
Copy link
Contributor

@magicarm22 Please check this update

I had to place "no" in quotes so it works on my Windows machine and idf-component-manager 1.4.1

Copy link

github-actions bot commented Feb 1, 2024

Messages
📖 Good Job! All checks are passing!

👋 Welcome tore-espressif, thank you for your first contribution to espressif/idf-component-manager project!

📘 Please check project Contributions Guide of the project for the contribution checklist, information regarding code and documentation style, testing and other topics.

Pull request review and merge process you can expect

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  4. If the change is approved and passes the tests it is merged into the default branch

Generated by 🚫 dangerJS against 7f36ea6

@github-actions github-actions bot changed the title fix(docs): Require field must be in quotes fix(docs): Require field must be in quotes (PACMAN-791) Feb 1, 2024
@magicarm22
Copy link
Contributor

@tore-espressif Thanks for your contribution, LGTM!

@kumekay
Copy link
Collaborator

kumekay commented Feb 2, 2024

@magicarm22 I remember we handled the Norway problem while designing this feature.

@tore-espressif How exactly it breaks for you? The behavior should be the same for both no - parsed as boolean false and "no" - string "no"

@tore-espressif
Copy link
Contributor Author

@kumekay Here is the error log:

 ERROR: A problem was found in the manifest file
  C:/github_repos/esp-bsp/examples/display/main\idf_component.yml:

  Unknown boolean field "require" in the manifest file that may affect build
  result



  SUGGESTION: This component may be using a newer version of the component
  manager.

  You can try to update the component manager by running:

      C:\Espressif\python_env\idf5.3_py3.8_env\Scripts\python.exe -m pip install --upgrade idf-component-manager



Call Stack (most recent call first):
  C:/esp_repos/esp-idf/master/tools/cmake/project.cmake:710 (idf_build_process)
  CMakeLists.txt:9 (project)

This is the manifest

description: BSP Display example

dependencies:
  esp_wrover_kit:
    version: "^1.0.0"
    require: no
    override_path: "../../../bsp/esp_wrover_kit"

@kumekay kumekay added the Type: Bug 🐛 Something isn't working label Feb 6, 2024
@kumekay
Copy link
Collaborator

kumekay commented Feb 6, 2024

@tore-espressif Thank you for the log, no without quotes should be supported, we will fix it

@kumekay
Copy link
Collaborator

kumekay commented Feb 23, 2024

@tore-espressif We fixed support for no without quotes in 6ae82df and v1.5.2

@kumekay kumekay closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants