Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[custom] Remove platforms #4598

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Conversation

kbx81
Copy link
Member

@kbx81 kbx81 commented Jan 21, 2025

Description:

SSIA

Note: Some guides/cookbooks will also need to be modified/rewritten (outside this PR).

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#8119

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added removed in /index.rst when creating new documents for new components or cookbook.

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit c09aacb
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/679030b559a47300087dfa92
😎 Deploy Preview https://deploy-preview-4598--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kbx81 kbx81 requested a review from jesserockz January 21, 2025 06:09
@kbx81 kbx81 changed the title [custom] Remove platform [custom] Remove platforms Jan 21, 2025
Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a redirect for every removed page eg:

/components/binary_sensor/custom* /guides/contributing#a-note-about-custom-components 301

@esphome
Copy link

esphome bot commented Jan 21, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@esphome esphome bot marked this pull request as draft January 21, 2025 18:45
@kbx81 kbx81 marked this pull request as ready for review January 21, 2025 23:49
@esphome esphome bot requested a review from jesserockz January 21, 2025 23:49
@jesserockz jesserockz merged commit b561a36 into esphome:next Jan 21, 2025
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants