Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database to work with Oauth #47

Closed
ryantanaka opened this issue Feb 26, 2018 · 7 comments
Closed

Update database to work with Oauth #47

ryantanaka opened this issue Feb 26, 2018 · 7 comments

Comments

@ryantanaka
Copy link
Contributor

@jygh98, can you meet this Thursday 3:00pm so we can update the database on the server to work with Oauth? Once we pull your merged changes onto the server, we can make sure all the functionalities are working properly and get #40, #33, #31, #29, #23, #7 closed on the issues list.

@jygh98
Copy link
Member

jygh98 commented Feb 27, 2018

@ryantanaka 👍

@carlosparadis
Copy link
Member

As discussed today with @jygh98 , my understanding is that a new table oauth was created. But the current status of the user and users table which is no longer used by survey_admin (or any other app on the server), remains. Can someone confirm? I would like to keep dead code and tables to a minimum to avoid ambiguity and confusion down the road.

@ryantanaka
Copy link
Contributor Author

@ryantanaka

note 3/2/18:

Still need to do #40, #33, #31, #29

@ryantanaka
Copy link
Contributor Author

@carlosparadis, You are right about the oauth table. I confirmed that users is not needed. I will go ahead and remove it from the database.

@jygh98, hey jason, am i missing something? i can't seem to find code referencing to the is_deployed column of the deployed_url table or any type of feature associated to #40 when running the web app locally. is #40 done or do I need to code that up? LMK, thanks

@ryantanaka
Copy link
Contributor Author

@jygh98, actually nvm I see the code on your fork 33-allow-to-edit-survey-admin.

@jygh98
Copy link
Member

jygh98 commented Mar 7, 2018

@ryantanaka 👍

@ryantanaka
Copy link
Contributor Author

the database is set up with the oauth table (both jason and I are added at the moment), I am closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants