Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for the semaphore when updating the robot model #1851

Open
andchiind opened this issue Dec 6, 2024 · 1 comment
Open

Remove the need for the semaphore when updating the robot model #1851

andchiind opened this issue Dec 6, 2024 · 1 comment
Labels
backend Backend related functionality frontend Frontend related functionality improvement Improvement to existing functionality

Comments

@andchiind
Copy link
Contributor

Describe the improvement you would like to see
Currently we use a semaphore to avoid different robot updates from overwriting each other. Instead we should use the ExecuteUpdateAsync function to update values on the model individually, so that the battery updates don't overwrite robot status for instance. This also means that the signalR messages for robot updates should also specify which robot value has been updated.

How will this change existing functionality?
It will remove the need for the semaphore, which is important as semaphores only work if we only have one Flotilla instance running in Kubernetes.

How will this improvement affect the current Threat Model?
N/A

@andchiind andchiind added improvement Improvement to existing functionality backend Backend related functionality frontend Frontend related functionality labels Dec 6, 2024
@andchiind
Copy link
Contributor Author

Related: #1796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant