Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend time has changed to UTC so now all comparisons in the frontend are one hour off #1146

Closed
andchiind opened this issue Nov 9, 2023 · 0 comments · Fixed by #1330
Closed

Backend time has changed to UTC so now all comparisons in the frontend are one hour off #1146

andchiind opened this issue Nov 9, 2023 · 0 comments · Fixed by #1330
Assignees
@UsamaEquinorAFK
Labels
backend Backend related functionality bug Something isn't working frontend Frontend related functionality

Comments

@andchiind
Copy link
Contributor

Describe the bug
Backend time is one hour behind central european time.

To Reproduce
Alert banners are not triggered even though missions fail immediately with the in-memory database.

Expected behavior
The time format should be the same in the frontend and backend. If we stay with UTC time in the backend then we should have a standard format for creating dates in the frontend.

Screenshots
image
@andchiind andchiind added bug Something isn't working backend Backend related functionality frontend Frontend related functionality labels Nov 9, 2023
@Eddasol Eddasol self-assigned this Nov 27, 2023
@Eddasol Eddasol linked a pull request Nov 27, 2023 that will close this issue
Use local time for missionRunResponse #1222
Closed
@Eddasol Eddasol removed a link to a pull request Jan 3, 2024
Use local time for missionRunResponse #1222
Closed
@Eddasol Eddasol linked a pull request Jan 5, 2024 that will close this issue
Use local time for missionRunResponse #1222
Closed
@Eddasol Eddasol removed their assignment Jan 5, 2024
@UsamaEquinorAFK UsamaEquinorAFK self-assigned this Jan 10, 2024
@Eddasol Eddasol linked a pull request Jan 12, 2024 that will close this issue
Change utc to local time upon json serialization #1330
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UsamaEquinorAFK UsamaEquinorAFK

Labels
backend Backend related functionality bug Something isn't working frontend Frontend related functionality
Projects
None yet
Milestone
No milestone
3 participants
@andchiind @Eddasol @UsamaEquinorAFK