Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core changes for Accessibility break Custom Reports search form #5

Open
drn05r opened this issue Aug 11, 2020 · 0 comments
Open

Core changes for Accessibility break Custom Reports search form #5

drn05r opened this issue Aug 11, 2020 · 0 comments
Labels

Comments

@drn05r
Copy link
Contributor

drn05r commented Aug 11, 2020

Changes to EPrints 3.4.2 to improve Accessibility have created an issue where fields for all search forms under Custom Reports tab are displayed at once. This is due to a move from using table, tr and td elements to using div elements. This can be remedied by switching the current table element used on line 638 of lib/plugins/EPrints/Plugin/Screen/Report.pm from:

my $table = $repo->make_element( "table", class=>"ep_search_fields", id=>$formid, style=>"display: none" );

to:

my $table = $repo->make_element( "div", class=>"ep_search_fields ep_tabl e", id=>$formid, style=>"display: none" );

However, this will then break things for pre 3.4.2 versions of EPrints. Therefore some conditional statement to check which version should be used. There does not currently seem to be an easy way of checking whether a version is higher or lower than another. So the conditional statement might be a little long-winded.

@drn05r drn05r added the bug label Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant