Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing phrase? #93

Open
photomedia opened this issue Jul 9, 2019 · 4 comments
Open

missing phrase? #93

photomedia opened this issue Jul 9, 2019 · 4 comments

Comments

@photomedia
Copy link

Is there a phrase missing?
I have this in my report for search_terms:

["lib/irstats2:view:search_terms" not defined]

@mpbraendle
Copy link

We have this in lib/lang/en/phrases/irstats2.xml

<epp:phrase id="lib/irstats2:view:search_terms">Search Terms</epp:phrase>

@photomedia
Copy link
Author

I installed from the Bazaar (http://bazaar.eprints.org/512/) and the phrase file there: https://bazaar.eprints.org/512/1/lang/en/phrases/irstats2.xml doesn't have it, it only has this:

<epp:phrase id="lib/irstats2/type:search_terms">Search terms</epp:phrase>

@mpbraendle
Copy link

I checked my SVN log when I installed IRStats2 4 years ago. Indeed it seems that we have added the <epp:phrase id="lib/irstats2:view:search_terms">Search Terms</epp:phrase> and that it was missing in the original phrase file.

goetzk added a commit to eprintsug/irstats2 that referenced this issue Jan 11, 2021
Fix supplied by mpbraendle.
@goetzk
Copy link
Contributor

goetzk commented Jan 11, 2021

I've committed a fix for this (un-merged). If you're happy this change is still required I'll merge it in to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants