mobile: Fix the internet disconnection error mapping #38169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fredy Wijaya <[email protected]>
Signed-off-by: Fredy Wijaya <[email protected]>
fredyw
requested review from
RyanTheOptimist,
alyssawilk and
abeyad
as code owners
|
/assign @abeyad |
|
cc @RenjieTang |
abeyad
approved these changes
Jan 23, 2025
bazmurphy
pushed a commit
to bazmurphy/envoy
that referenced
this pull request
Jan 29, 2025
This PR fixes the error mapping for the internet disconnection in Cronvoy to only check the network status instead of looking at the other errors because when the network is offline, the only logical error is `ERR_INTERNET_DISCONNECTED` irrespective of the other errors. Risk Level: low Testing: unit test Docs Changes: n/a Release Notes: n/a Platform Specific Features: android --------- Signed-off-by: Fredy Wijaya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error mapping for the internet disconnection in Cronvoy to only check the network status instead of looking at the other errors because when the network is offline, the only logical error is
ERR_INTERNET_DISCONNECTEDirrespective of the other errors.Risk Level: low
Testing: unit test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: android