ext_proc: change default sampling to false inheriting from parent decision #37794
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fernando Cainelli <[email protected]>
cainelli
changed the title
|
/retest |
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
cainelli
requested review from
tyxia,
mattklein123 and
yanavlasov
as code owners
cainelli
commented
Dec 23, 2024
| bool finished_; | ||
| bool context_injected_{false}; | ||
| bool sampled_{false}; | ||
| bool finished_{false}; |
There was a problem hiding this comment.
I noticed there are still some flake tests in CI and wonder if might be it.
There was a problem hiding this comment.
Do you mean this PR should fix the flakiness. Or do you mean there are still some flakiness with this PR
There was a problem hiding this comment.
The first commit in this PR failed with flake test, after initializing the variables here it looks good.
tyxia
approved these changes
Jan 6, 2025
| bool finished_; | ||
| bool context_injected_{false}; | ||
| bool sampled_{false}; | ||
| bool finished_{false}; |
There was a problem hiding this comment.
Do you mean this PR should fix the flakiness. Or do you mean there are still some flakiness with this PR
|
@tyxia would you need an extra reviewer before merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: ext_proc: change default sampling decision to false
Fixes: #37783
Additional Description: Default to using the parent span's sampled status instead of true (default in StreamOptions), so that we don't emit orphan spans for all ext_proc streams where the parent span is not sampled. That's the same issue seen in Lua httpCall (#33200) and ext_authz (#19343).
Risk Level: Low
Testing: changed the tracing integration test behavior and validated in production.