Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge GameAttr with BaseAttr #200

Open
YoruCathy opened this issue Feb 12, 2025 · 1 comment
Open

Merge GameAttr with BaseAttr #200

YoruCathy opened this issue Feb 12, 2025 · 1 comment
Assignees
@YoruCathy

Comments

@YoruCathy
Copy link
Member

Describe the new feature
Remove the GameAttr and merge all the features in GameAttr into BaseAttr since the APIs in GameAttr are needed for all objects.

Test cases
No plans for this specifically. But we should add test cases for all the APIs in BaseAttr. I'll create a separate issue for all the test cases.

Development plan
Should be quick. Let's try to get this done next week.

Environment

  • System: Windows 7/8/10/WSL, Ubuntu 20.04/18.04, etc.
  • Python: 3.10
@YoruCathy YoruCathy self-assigned this Feb 12, 2025
@YoruCathy
Copy link
Member Author

Make sure you update the code on both Python and Unity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YoruCathy YoruCathy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YoruCathy