Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group example in docs returns wrong type #111

Closed
Janiczek opened this issue Sep 3, 2018 · 4 comments
Closed

group example in docs returns wrong type #111

Janiczek opened this issue Sep 3, 2018 · 4 comments

Comments

@Janiczek
Copy link
Contributor

Janiczek commented Sep 3, 2018

group returns List (a, List a) but the example doesn't reflect that:

group  [1,2,2,3,3,3,2,2,1] == [[1],[2,2],[3,3,3],[2,2],[1]]
@Chadtech
Copy link
Collaborator

Chadtech commented Sep 3, 2018 •
edited
Loading

Thanks! I didnt notice this. Yeah in 8.0.0 the group functions changed pretty fundamentally. I'll fix this soon.

@pzp1997
Copy link
Contributor

pzp1997 commented Sep 4, 2018

I think we should start using elm-verify-examples so that this will not happen in the future. See issue #50.

@pzp1997 pzp1997 mentioned this issue Sep 21, 2018
Merged
@Chadtech
Copy link
Collaborator

Sounds good to me. Ilias recommended that too. Lets do it.

@Chadtech
Copy link
Collaborator

Chadtech commented Oct 8, 2018

We are using elm-verify-examples now, and this particular issue was resolved.

@Chadtech Chadtech closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Janiczek @Chadtech @pzp1997