Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join can be used on all types #136

Open
elliotchance opened this issue May 12, 2019 · 0 comments
Open

Join can be used on all types #136

elliotchance opened this issue May 12, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@elliotchance
Copy link
Owner

In a recent version, I introduced fmt.Stringer, see:

https://github.com/elliotchance/pie/blob/master/functions/float64s.go#L19-L20

mightBeString.String() will be replaced with a fmt.Sprintf("%v", mightBeString) for types that do not implement fmt.Stringer.

The functions that support this as tagged with an "S" in the Functions list. This means that Join could be used on all types and StringSliceType can be removed :)
@elliotchance elliotchance added the enhancement New feature or request label May 12, 2019
@elliotchance elliotchance mentioned this issue May 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elliotchance