Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root: add Plausible #82

Closed
wants to merge 1 commit into from
Closed

Root: add Plausible #82

wants to merge 1 commit into from

Conversation

cassidyjames
Copy link
Contributor

Fixes #76

@cassidyjames cassidyjames added the Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix. label Apr 16, 2021
@cassidyjames cassidyjames requested a review from btkostner April 16, 2021 19:44
@btkostner
Copy link
Contributor

So, right now there seems to be a bit of a JS bug where the checkout doesn't get sent by js and gets added to the url. So I think that's a blocker for this because we don't want to track people's address in plausible

@cassidyjames
Copy link
Contributor Author

cassidyjames commented Apr 19, 2021

@btkostner where is this happening? I'm seeing the checkout URL with a hash in it, but as that's not on our domain, I don't think it would be picked up by Plausible. Unless I'm missing something.

@btkostner
Copy link
Contributor

It happens with a JS error during the checkout process. Specifically when JS is not running and you click the shipping rates button.

@cassidyjames
Copy link
Contributor Author

@btkostner if we're requiring JS anyway, can we only enable that button when JS is running? Otherwise I'm not sure how we'd get into that state.

@btkostner
Copy link
Contributor

@cassidyjames That was my first reaction, but looking into it seemed extremely hackey and too much work for the alternative, which is just making the form a POST method that would error out.

@cassidyjames cassidyjames removed the Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix. label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Plausible
2 participants