Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make item descriptions translatable #163

Open
ryonakano opened this issue Sep 8, 2021 · 1 comment
Open

Make item descriptions translatable #163

ryonakano opened this issue Sep 8, 2021 · 1 comment
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a priority, but something that might be nice

Comments

@ryonakano
Copy link
Contributor

Problem

store elementary io_products_179516813

The store page itself supports translations, but currently item descriptions, item types at the top of the page, etc. are not translatable and shown in English regardless of your language settings.

Proposal

Make item descriptions, item types at the top of the page, etc. translatable and shown in a language you selected.

Prior Art

N/A

@ryonakano ryonakano added Needs Design Waiting for input from the UX team Priority: Wishlist Not a priority, but something that might be nice labels Sep 8, 2021
@btkostner
Copy link
Contributor

All of that information is coming directly from the Printful API, so it's all dynamic (vs the hard set translatable text), which makes it pretty hard to translate. I'm going to link with this issue because once we start having custom data in the repo, it will probably be easier to also have custom copy.

linking #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a priority, but something that might be nice
Projects
None yet
Development

No branches or pull requests

2 participants