Persist current search term until intentionally changed #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1508
In
masteras soon as you edit a document in a way that results in a "selection_changed" signal being emitted (e.g. copy, cut , paste, select etc) the current search term is lost so has to be re-entered to search for the next occurrence, which is most annoying.This PR results in the search term persisting until a new search is intentionally started by pressing
Control + For by editing the search bar or by revealing the search bar. Making a new selection in the document no longer replaces the search term in the searchbar unless the search term is blank. If you want to select a new search term then it is necessary to pressEscor otherwise clear the current search first. There does not seem to be a way of automatically detecting whether a text selection in the document is incidental or meant to be a new search term.