Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how we import Playwright utilities in the Recorder #418

Open
justinkambic opened this issue May 18, 2023 · 1 comment
Open

Improve how we import Playwright utilities in the Recorder #418

justinkambic opened this issue May 18, 2023 · 1 comment
Labels
chore

Comments

@justinkambic
Copy link
Contributor

Task summary

As a part of GA process we encountered some import issues between the Recorder, Synthetics, and the Elastic Playwright hook. As such, we implemented some additional changes to #415 when we bumped to v1.

To resolve this issue, we must eliminate the postinstall script and allow the normal installation flow to continue working.

Linked resources

No response

Additional information

No response
@paulb-elastic paulb-elastic changed the title [Other] Resolve pre-GA concerns Improve how we imports Playwright utilities in the Recorder Jun 19, 2023
@paulb-elastic
Copy link
Contributor

Without this, we are at risk of missing Playwright utilities needed when bundling newer versions of the Recorder with newer versions of Playwright

@justinkambic justinkambic changed the title Improve how we imports Playwright utilities in the Recorder Improve how we import Playwright utilities in the Recorder Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinkambic @paulb-elastic