Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] More readable functions #258

Open
kyungeunni opened this issue May 20, 2022 · 0 comments
Open

[Chore] More readable functions #258

kyungeunni opened this issue May 20, 2022 · 0 comments
Labels

Comments

@kyungeunni
Copy link
Contributor

kyungeunni commented May 20, 2022

Summary

There are a few functions in the codebase that is quite long so that it is quite difficult to comprehend the changes whenever we update or make a fix.

For instance, onTest function in electron/execution.ts is 163 lines long and it contains several nested functions and the inlined logic mixed up together. It'd be easier to maintain and review the code if we can divide up the code into smaller chunks, even into a separate file if it deserves it. The good example is #256. It was a quite small bug fix but I needed to extend most of the collapsed part of the code when reviewing as I wasn't sure if the change is part of the main logic or applied to a nested helper / utill function.

Why is this important?

It'd help us understand and maintain the code better and easier.

@kyungeunni kyungeunni added enhancement New feature or request chore and removed enhancement New feature or request labels May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant