Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] Use architecture-specific elser model #205851

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Jan 8, 2025

Closes #205852

When installing the Obs knowledge base it will always install the model .elser_model_2.
For Linux with an x86-64 CPU an optimised version of Elser exists (elser_model_2_linux-x86_64). We should use that when possible.

After this change the inference endpoint will use .elser_model_2_linux-x86_64 on supported hardware:
image

@sorenlouv sorenlouv marked this pull request as ready for review January 8, 2025 11:39
@sorenlouv sorenlouv requested a review from a team as a code owner January 8, 2025 11:39
@sorenlouv sorenlouv marked this pull request as draft January 8, 2025 11:39
@sorenlouv sorenlouv added backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development release_note:fix ci:project-deploy-observability Create an Observability project labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@sorenlouv
Copy link
Member Author

/oblt-deploy

@sorenlouv sorenlouv removed the ci:project-deploy-observability Create an Observability project label Jan 8, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

@sorenlouv
Copy link
Member Author

/oblt-deploy

@sorenlouv sorenlouv marked this pull request as ready for review January 8, 2025 14:56
@botelastic botelastic bot added the Team:Obs AI Assistant Observability AI Assistant label Jan 8, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@dgieselaar dgieselaar added v9.0.0 v8.18.0 v8.17.1 backport:version Backport to applied version labels and removed backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Jan 8, 2025
@sorenlouv sorenlouv merged commit ad3b988 into elastic:main Jan 8, 2025
28 checks passed
@sorenlouv sorenlouv deleted the use_arch_specific_model_id branch January 8, 2025 18:59
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12677226399

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 8, 2025
)

Closes elastic#205852

When installing the Obs knowledge base it will always install the model
`.elser_model_2`.
For Linux with an x86-64 CPU an optimised version of Elser exists
(`elser_model_2_linux-x86_64`). We should use that when possible.

After this change the inference endpoint will use
`.elser_model_2_linux-x86_64` on supported hardware:

![image](https://github.com/user-attachments/assets/fedc6700-877a-47ab-a3b8-055db53407d0)

(cherry picked from commit ad3b988)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.17:
- [Discover] Fix issue where KEEP columns are not applied after Elasticsearch error (#205833)
- [Security Solution] Implement refactoring remark from PR #201731 (#204022)
- [Security Solution] List all policies to display integrations properly (#205103)
- [Security Assistant] Move security AI assistant button into global nav bar (#203060)
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 205851

Questions ?

Please refer to the Backport tool documentation

@sorenlouv
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Jan 8, 2025
)

Closes elastic#205852

When installing the Obs knowledge base it will always install the model
`.elser_model_2`.
For Linux with an x86-64 CPU an optimised version of Elser exists
(`elser_model_2_linux-x86_64`). We should use that when possible.

After this change the inference endpoint will use
`.elser_model_2_linux-x86_64` on supported hardware:

![image](https://github.com/user-attachments/assets/fedc6700-877a-47ab-a3b8-055db53407d0)

(cherry picked from commit ad3b988)
sorenlouv added a commit that referenced this pull request Jan 9, 2025
) (#205978)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Obs AI Assistant] Use architecture-specific elser model
(#205851)](#205851)

<!--- Backport version: 9.6.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Søren
Louv-Jansen","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T18:59:20Z","message":"[Obs
AI Assistant] Use architecture-specific elser model (#205851)\n\nCloses
https://github.com/elastic/kibana/issues/205852\n\nWhen installing the
Obs knowledge base it will always install the
model\n`.elser_model_2`.\nFor Linux with an x86-64 CPU an optimised
version of Elser exists\n(`elser_model_2_linux-x86_64`). We should use
that when possible.\n\nAfter this change the inference endpoint will
use\n`.elser_model_2_linux-x86_64` on supported
hardware:\n\n![image](https://github.com/user-attachments/assets/fedc6700-877a-47ab-a3b8-055db53407d0)","sha":"ad3b9880c792833e7590a60d57b65e08ecbd9b25","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs
AI Assistant","backport:version","v8.18.0","v8.17.1"],"title":"[Obs AI
Assistant] Use architecture-specific elser
model","number":205851,"url":"https://github.com/elastic/kibana/pull/205851","mergeCommit":{"message":"[Obs
AI Assistant] Use architecture-specific elser model (#205851)\n\nCloses
https://github.com/elastic/kibana/issues/205852\n\nWhen installing the
Obs knowledge base it will always install the
model\n`.elser_model_2`.\nFor Linux with an x86-64 CPU an optimised
version of Elser exists\n(`elser_model_2_linux-x86_64`). We should use
that when possible.\n\nAfter this change the inference endpoint will
use\n`.elser_model_2_linux-x86_64` on supported
hardware:\n\n![image](https://github.com/user-attachments/assets/fedc6700-877a-47ab-a3b8-055db53407d0)","sha":"ad3b9880c792833e7590a60d57b65e08ecbd9b25"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205851","number":205851,"mergeCommit":{"message":"[Obs
AI Assistant] Use architecture-specific elser model (#205851)\n\nCloses
https://github.com/elastic/kibana/issues/205852\n\nWhen installing the
Obs knowledge base it will always install the
model\n`.elser_model_2`.\nFor Linux with an x86-64 CPU an optimised
version of Elser exists\n(`elser_model_2_linux-x86_64`). We should use
that when possible.\n\nAfter this change the inference endpoint will
use\n`.elser_model_2_linux-x86_64` on supported
hardware:\n\n![image](https://github.com/user-attachments/assets/fedc6700-877a-47ab-a3b8-055db53407d0)","sha":"ad3b9880c792833e7590a60d57b65e08ecbd9b25"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/205951","number":205951,"state":"OPEN"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:fix Team:Obs AI Assistant Observability AI Assistant v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Obs AI Assistant] Use hardware optimised version of Elser for Linux x86-64
4 participants