From dca136d8d80900649202f2e94b10c69f2b962b4a Mon Sep 17 00:00:00 2001 From: Marc Guasch Date: Mon, 30 Dec 2024 02:14:20 -0800 Subject: [PATCH] Revert "Do not skip npcap installation for system tests" This reverts commit 90a8265adf0430f13529a82b38a85a782920b93c. --- x-pack/packetbeat/magefile.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/x-pack/packetbeat/magefile.go b/x-pack/packetbeat/magefile.go index 220c430e5d8..5e938cbbda7 100644 --- a/x-pack/packetbeat/magefile.go +++ b/x-pack/packetbeat/magefile.go @@ -137,7 +137,12 @@ func TestPackages() error { } func SystemTest(ctx context.Context) error { - mg.SerialDeps(xpacketbeat.GetNpcapInstaller, devtools.BuildSystemTestBinary) + // Buildkite (CI) images have preinstalled npcap + if os.Getenv("CI") == "true" { + mg.SerialDeps(devtools.BuildSystemTestBinary) + } else { + mg.SerialDeps(xpacketbeat.GetNpcapInstaller, devtools.BuildSystemTestBinary) + } args := devtools.DefaultGoTestIntegrationArgs() args.Packages = []string{"./tests/system/..."}